Opened 5 years ago

Closed 4 years ago

#13105 closed defect (fixed)

[patch] TorBrowser creates two icons in OS X Dock - confusing

Reported by: teor Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

TorBrowser 3.6.5 creates an additional icon in the dock every time it is launched. This could cause user confusion:

  • Why do I have two copies of Tor Browser?
  • Which copy should I use?

If the user launches Tor Browser using the inner firefox icon, any arguments and paths supplied by the outer bundle script will be lost.

This patch changes the script to use "exec" rather than "open" to launch the Tor Browser. This makes sure there is only ever one TorBrowser icon in the dock. (Is there any reason "open" was used in the first place?)

The patch maintains the current behaviour when [-]-debug is used: the script launches the executable directly (without using exec or open) so it can get the exit status.

Version: TorBrowser-3.6.5-osx32_en-US.dmg

Child Tickets

Attachments (1)

exec-tor-browser-firefox-osx.patch (1.2 KB) - added by teor 5 years ago.
Teach Tor Browser to exec rather than open on OS X

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by teor

Teach Tor Browser to exec rather than open on OS X

comment:1 Changed 5 years ago by gk

Thanks for the patch. Have you tried the 4.0a2 (see: https://www.torproject.org/projects/torbrowser.html.en#downloads-alpha)? The 4.0 series (which is declared stable in a couple of weeks) should avoid this issue with a restructured directory layout.

comment:2 Changed 5 years ago by teor

No, I've just been pressing the "upgrade" button when my TorBrowser gets outdated.

Thanks for the pointer - I'll have a look.

comment:3 Changed 4 years ago by teor

Resolution: fixed
Status: newclosed

Fixed in 4.0, which is now stable.

Note: See TracTickets for help on using tickets.