Opened 4 years ago

Last modified 8 months ago

#13112 needs_revision defect

Some things are probably broken when we advertise multiple ORPorts and only some are reachable

Reported by: andrea Owned by: teor
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay, reachability, self-testing, needs-design, ipv6, tor-bridge, 034-triage-20180328, 034-removed-20180328
Cc: massar Actual Points: 0.2
Parent ID: #24403 Points: 1
Reviewer: Sponsor: SponsorV-can

Description

Observations on reachability testing made while fixing #12160:

  • We only have a 1-bit notion of reachability; if we get an incoming non-local connection, we assume reachability in onionskin_answer() and call router_orport_found_reachable() to publish a descriptor.
  • We should have a reachability bit per *advertised* ORPort to determine its inclusion in the published descriptor, and publish if and only if we have one or more reachable ORPorts.
  • To implement this, we need a way to link incoming testing circuits to a particular advertised ORPort; we don't know this from the port the underlying channel was listening on because reverse proxies might make this not one-to-one in general.
  • Arma suggests in IRC that netinfo cells know the IP the connection was attempted on and if they were extended with a port number they might provide a sufficient mechanism.

Child Tickets

Change History (22)

comment:1 Changed 4 years ago by teor

Keywords: lorax added
Milestone: Tor: 0.2.6.x-finalTor: 0.2.7.x-final

#12831 documents one case of brokenness: we only self-test IPv4, but we can easily advertise broken IPv6 wihout knowing.

comment:2 Changed 4 years ago by teor

Cc: massar added

comment:3 Changed 4 years ago by nickm

Status: newassigned

comment:4 Changed 4 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:6 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 in reply to:  1 Changed 2 years ago by teor

Severity: Normal

Replying to teor:

#12831 documents one case of brokenness: we only self-test IPv4, but we can easily advertise broken IPv6 wihout knowing.

And then the IPv6-enabled authorities vote them as not running after they do IPv6 reachability tests.

comment:8 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:9 Changed 19 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:10 Changed 19 months ago by nickm

Keywords: 027-triaged-in added

comment:11 Changed 19 months ago by nickm

Keywords: 027-triaged-in removed

comment:12 Changed 19 months ago by nickm

Keywords: 027-triaged-1-out removed

comment:13 Changed 19 months ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:14 Changed 18 months ago by nickm

Keywords: tor-relay reachability self-testing needs-design ipv6 tor-bridge added; lorax removed

comment:15 Changed 13 months ago by teor

Milestone: Tor: unspecifiedTor: 0.3.3.x-final
Parent ID: #24403
Points: 1
Sponsor: SponsorV-can
Version: Tor: unspecified

comment:16 Changed 12 months ago by teor

Owner: set to teor
Status: newassigned

Please see my branch bug13112_tree, which is based on #17782 (bug17782).
I expect this will need revision as we implement relay initiation of IPv6 ORPort reachability checks.

comment:17 Changed 12 months ago by teor

Actual Points: 0.2

comment:18 Changed 12 months ago by teor

Status: assignedneeds_revision

comment:19 Changed 11 months ago by teor

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

The 0.3.3 freeze deadline has passed, all these children of #24403 belong in 0.3.4

comment:20 Changed 9 months ago by nickm

Keywords: 034-triage-20180328 added

comment:21 Changed 9 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:22 Changed 8 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These needs_revision, tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if somebody does the necessary revision.

Note: See TracTickets for help on using tickets.