Opened 5 years ago

Closed 5 years ago

#13139 closed defect (fixed)

Fix backward compatibility with twisted 13.1 in ooniprobe

Reported by: hellais Owned by: hellais
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently ooniprobe requires twisted API 13.1. When running ooniprobe with an older version you will get this error message:

Traceback (most recent call last):
  File "/usr/bin/ooniprobe", line 16, in <module>
    from ooni.oonicli import runWithDirector
  File "/usr/lib/python2.7/dist-packages/ooni/oonicli.py", line 11, in
<module>
    from ooni.settings import config
  File "/usr/lib/python2.7/dist-packages/ooni/settings.py", line 7, in
<module>
    from twisted.internet.endpoints import TCP4ClientEndpoint,
connectProtocol
ImportError: cannot import name connectProtocol

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by hellais

Component: - Select a componentOoni
Owner: set to hellais

comment:2 Changed 5 years ago by hellais

A PR fixing this bug has been submitted here: https://github.com/TheTorProject/ooni-probe/pull/352

comment:3 Changed 5 years ago by hellais

Status: newneeds_review

comment:4 Changed 5 years ago by hellais

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.