OR address is in host order in INTRODUCE2 cell
|Reported by:||asn||Owned by:|
|Severity:||Keywords:||tor-hs, tor-client, 2016-bug-retrospective|
It seems that the IP address of the RP is in host order in INTRODUCE2 cells, when it should be in network order. Here is the bad code https://gitweb.torproject.org/tor.git/blob/f8f0cb0443c0709454c9223f25266ec1b0c464b8:/src/or/rendclient.c#l274 :
and here is the code that tries to parse it https://gitweb.torproject.org/tor.git/blob/f8f0cb0443c0709454c9223f25266ec1b0c464b8:/src/or/rendservice.c#l1785 :
tor_addr_from_ipv4n(&extend_info->addr, get_uint32(buf + 1));
Roger found that the bug was introduced in 960a0f0a.
That said, rendezvous seems to work IRL so this bug is not so severe. Rendezvous is completed properly, because the HS probably uses the identity digest to map to a node.
I encountered that bug while fiddling with #12844 and trying to use a relay I just made as my RP. It didn't work.
Change History (32)
comment:2 follow-ups: ↓ 4 ↓ 5 ↓ 9 Changed 3 years ago by arma
- Milestone changed from Tor: 0.2.6.x-final to Tor: 0.2.5.x-final
- Priority changed from normal to major
comment:27 Changed 3 years ago by arma
- Milestone changed from Tor: 0.2.5.x-final to Tor: 0.2.4.x-final
comment:28 Changed 3 years ago by Sebastian
- Resolution set to fixed
- Status changed from needs_review to closed