Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13187 closed defect (fixed)

Building libfte/fteproxy is broken in our nightlies

Reported by: gk Owned by: kpdyer
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-gitian
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It seems commit e2786aefd212c23e529479ceda88d6a250f6108c broke our gitian setup:

+ ln -s /home/ubuntu/install/gmp thirdparty/gmp
ln: failed to create symbolic link `thirdparty/gmp': No such file or directory

Child Tickets

Change History (17)

comment:1 Changed 5 years ago by kpdyer

Temporary fix: https://github.com/kpdyer/libfte/pull/13

Please leave this ticket open. I'll address it properly soon. (https://github.com/kpdyer/libfte/issues/14)

comment:2 Changed 5 years ago by gk

Thanks, but it is still broken:

+ make
make: *** No targets specified and no makefile found.  Stop.

comment:3 Changed 5 years ago by kpdyer

Indeed. Sorry about that. Try again from master.

Last edited 5 years ago by kpdyer (previous) (diff)

comment:4 Changed 5 years ago by gk

I get now:

running build_ext^M
building 'fte.cDFA' extension^M
error: Unable to find vcvarsall.bat^M

comment:5 Changed 5 years ago by kpdyer

Sorry, again. Too ambitious on what I cut out. Makefile fully restored with appropriate parts removed.

comment:6 Changed 5 years ago by gk

Summary: Building libfte is broken in our nightliesBuilding libfte/fteproxy is broken in our nightlies

We are almost there it seems:

+ mkdir -p /home/ubuntu/install/Docs/fteproxy
+ cp -an COPYING README.md /home/ubuntu/install/Docs/fteproxy
cp: cannot stat `COPYING': No such file or directory

Btw, instead of tweaking the sources I don't mind tweaking the gitian descriptors...

comment:7 Changed 5 years ago by kpdyer

Sounds good.

In gitian/descriptors/linux/gitian-pluggable-transports.yml can you:

  • Remove line 186.
  • On line 195 change COPYING to LICENSE.

Then do the same for mac, windows too?

That should, hopefully, be the last of it.

comment:8 Changed 5 years ago by gk

Well, unless we bump the tags in the non-nightly version files that would break non-nightly builds. E.g. in fteproxy's 0.2.17 which we use for example in the alpha series there is no LICENSE file. So, I am inclined to leave the nightlies broken if I have to. :) Or is it sane to switch to 0.2.18?

comment:9 Changed 5 years ago by kpdyer

Gotcha.

I've updated master of fteproxy, your issue from comment:6 is now fixed.

comment:10 Changed 5 years ago by gk

Building for OS X is broken now:

home/ubuntu/build/apple-osx/bin/i686-apple-darwin11-g++ -pthread -shared -L/usr/lib/apple/SDKs/MacOSX10.6.sdk/usr/lib/ -L/usr/lib/apple/SDKs/MacOSX10.6.sdk/usr/lib/system/ -F/usr/lib/apple/SDKs/MacOSX10.6.sdk/System/Library/Frameworks -mmacosx-version-min=10.5 -L/home/ubuntu/install/Tor -I/home/ubuntu/install/gmp/include -I/usr/lib/apple/SDKs/MacOSX10.6.sdk/usr/include/ -I/usr/lib/gcc/i686-apple-darwin10/4.2.1/include/ -I. -L/usr/lib/apple/SDKs/MacOSX10.6.sdk/usr/lib/ -L/usr/lib/apple/SDKs/MacOSX10.6.sdk/usr/lib/system/ -F/usr/lib/apple/SDKs/MacOSX10.6.sdk/System/Library/Frameworks -mmacosx-version-min=10.5 -L/usr/lib/apple/SDKs/MacOSX10.6.sdk/usr/lib/i686-apple-darwin10/4.2.1 -I/home/ubuntu/install/gmp/include -L/home/ubuntu/install/gmp/lib build/temp.linux-i686-2.7/fte/rank_unrank.o build/temp.linux-i686-2.7/fte/cDFA.o -Lthirdparty/gmp/bin -Lthirdparty/gmp/lib -lgmp -o build/lib.linux-i686-2.7/fte/cDFA.so
ld: warning: directory not found for option '-L/home/ubuntu/install/Tor'
ld: warning: directory not found for option '-Lthirdparty/gmp/bin'
ld: warning: directory not found for option '-Lthirdparty/gmp/lib'
Undefined symbols for architecture i386:
  "_PyType_Ready", referenced from:
      _initcDFA in cDFA.o
  "_Py_InitModule4", referenced from:
      _initcDFA in cDFA.o
  "_PyModule_AddObject", referenced from:
      _initcDFA in cDFA.o
  "_PyTuple_GetItem", referenced from:
      DFA_init(DFAObject*, _object*, _object*)in cDFA.o
  "_PyErr_SetString", referenced from:
      DFA_init(DFAObject*, _object*, _object*)in cDFA.o
      DFA__unrank(_object*, _object*)in cDFA.o
      DFA__rank(_object*, _object*)in cDFA.o
  "_PyString_AsString", referenced from:
      DFA_init(DFAObject*, _object*, _object*)in cDFA.o
      DFA__unrank(_object*, _object*)in cDFA.o
  "_PyInt_AsLong", referenced from:
      DFA_init(DFAObject*, _object*, _object*)in cDFA.o
  "_PyArg_ParseTuple", referenced from:
      DFA__getNumWordsInLanguage(_object*, _object*)in cDFA.o
      DFA__unrank(_object*, _object*)in cDFA.o
      DFA__rank(_object*, _object*)in cDFA.o
  "_PyLong_FromString", referenced from:
      DFA__getNumWordsInLanguage(_object*, _object*)in cDFA.o
      DFA__rank(_object*, _object*)in cDFA.o
  "_PyNumber_ToBase", referenced from:
      DFA__unrank(_object*, _object*)in cDFA.o
  "_Py_BuildValue", referenced from:
      DFA__unrank(_object*, _object*)in cDFA.o
  "_PyObject_Free", referenced from:
      DFA_dealloc(_object*)      in cDFA.o
  "_PyExc_RuntimeError", referenced from:
      DFA_init(DFAObject*, _object*, _object*)in cDFA.o
      DFA__unrank(_object*, _object*)in cDFA.o
      DFA__rank(_object*, _object*)in cDFA.o
ld: symbol(s) not found for architecture i386
collect2: ld returned 1 exit status
error: command '/home/ubuntu/build/apple-osx/bin/i686-apple-darwin11-g++' failed with exit status 1
make: *** [fte/cDFA.so] Error 1

comment:11 Changed 5 years ago by kpdyer

Did that error appear the first time last night?

comment:12 Changed 5 years ago by gk

No. It appeared some days ago but I had no time to report it earlier.

comment:13 Changed 5 years ago by kpdyer

Got it. Will investigate.

comment:14 Changed 5 years ago by kpdyer

Ok, I think this is sorted. Please try again.

comment:15 Changed 5 years ago by kpdyer

Resolution: fixed
Status: newclosed

comment:16 in reply to:  14 Changed 5 years ago by gk

Replying to kpdyer:

Ok, I think this is sorted. Please try again.

Looks good now, thanks.

comment:17 Changed 5 years ago by kpdyer

Great!

Note: See TracTickets for help on using tickets.