Opened 5 years ago

Closed 4 years ago

#13190 closed enhancement (fixed)

Fix build instructions in git readme

Reported by: snafu Owned by:
Priority: Very Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The build instructions in th readme found in the git repo currently read
./configure && make && make install
When it should be
./autogen.sh && ./configure && make && make install

Child Tickets

Attachments (1)

0001-improve-build-instructions.patch (657 bytes) - added by snafu 5 years ago.
proposed patch

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by snafu

proposed patch

comment:1 Changed 5 years ago by snafu

Status: newneeds_review

comment:2 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-final
Status: needs_reviewneeds_revision

Neither way is always correct. If you're building from git, you need to do "./autogen.sh"; if you're building from a source distribution, you don't.

comment:3 Changed 4 years ago by nickm

How about:

To build Tor from a source archive:
        ./configure && make && make install

To build Tor from a just-cloned git repository:
        sh autogen.sh && ./configure && make && make install

?

comment:4 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_revisionclosed

b1ca05d273eaef7477528c059ab0d1deb0dc9dab has that change.

Note: See TracTickets for help on using tickets.