Opened 10 years ago

Closed 7 years ago

#1323 closed defect (worksforme)

Tor doesn't recognize path which includes "#" in torrc

Reported by: ilter Owned by:
Priority: Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version: 0.2.1.24
Severity: Keywords: tor-client
Cc: ilter, nickm, Sebastian Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by phobos)

Hello,

I'm not sure it's a bug but maybe a notification can be written in default torrc file or on somewhere. When i want to
make my DataDirectory parameter in torrc file as: "DataDirectory /home/ilter/myTorNetwork#2/work/authorities/auth1"
it gives an error as below;

[warn] Couldn't open file for 'Log notice file /home/ilter/myTorNetwork': Is a directory

There is an explanation for "#" and "##" symbols on torrc. Maybe it can be update as below;

## Lines that begin with "## " try to explain what's going on. Lines
## that begin with just "#" are disabled commands: you can enable them
## by removing the "#" symbol.
+ ## Please notice that don't use these symbols on any parameters.

Thanks.
ilter

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (12)

comment:1 Changed 9 years ago by noino667

I'd suggest 2 possible remedies - as seen from a user POV.

  • simplest for implementers and users : # is interpreted as starting a comment ONLY at the beginning of a line, or

preceded only by SPACEs & equivalent (TABs). Gets my vote!

  • if it is felt that a mechanism is needed for adding comments at end of non-blank lines, then another mechanism is

needed for ESCAPING the start-of-comment character. Maybe \#, and then you need
to represent an \ since ## is out
of the question... is it worth the pain ?

Just my 2 monetary units,
Noino

comment:2 Changed 9 years ago by Sebastian

hrm. I think both isn't worth it. I'd just update the docs to reflect the truth

comment:3 Changed 9 years ago by phobos

Description: modified (diff)
Resolution: Nonewontfix
Status: newclosed

A documentation update is all that is needed for this. Otherwise, it's a lot of work for little gain.

comment:4 Changed 9 years ago by nickm

Resolution: wontfix
Status: closedreopened

Reopening; we need to change how we parse paths in the config file anyway so we can handle typical paths on international windows boxes.

comment:5 Changed 9 years ago by Sebastian

Nick, do you have some more info about the required changes for intl windows?

comment:6 Changed 9 years ago by nickm

See http://archives.seul.org/or/talk/May-2010/msg00067.html

I'm not sure what fix is needed to make this work right; probably some experimentation is needed to see which windows commands work right with international character sets, and which don't.

comment:7 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:8 Changed 9 years ago by nickm

(See also #1266)

comment:9 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

Still want to do it, but somebody needs to design for it.

comment:10 Changed 7 years ago by nickm

Keywords: tor-client added

comment:11 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:12 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final
Resolution: worksforme
Status: reopenedclosed

I think that the big configuration parsing refactoring that 0.2.5 is gearing up towards with #8351 will make handling interesting values from torrc much, much easier.

(As for paths with #, you can do that already by quoting the argument, which is supported and documented. So, closing.)

Note: See TracTickets for help on using tickets.