Opened 5 years ago

Closed 5 years ago

#13241 closed defect (fixed)

update_responses script generates incorrect hashes

Reported by: mcs Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: TorBrowserTeam201409
Cc: brade, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While testing TB 4.0a2 -> 4.0a3 updates, brade and I discovered that the SHA512 hashes generated by the update_responses script (for the update manifest XML files) are incorrect. The file path is being hashed rather than its contents.

I have a rough patch that seems to work; it may need some polish.

Child Tickets

Attachments (1)

0001-Bug-13241-incorrect-SHA512-hashes.patch (1.8 KB) - added by mcs 5 years ago.
a possible fix (may not be the best approach)

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by mcs

a possible fix (may not be the best approach)

comment:1 Changed 5 years ago by boklm

Resolution: fixed
Status: newclosed

The patch looks good.

I applied it to tb-update-response.git, and it is included on the branch on ticket #13253.

Note: See TracTickets for help on using tickets.