Opened 5 years ago

Closed 5 years ago

#13243 closed defect (fixed)

Password hashing unit tests are too slow

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay testing scrypt 026-deferrable
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The scrypt and pbkdf2 and pwbox tests I added for #12981 seem to run a bit slow. Running slow is kind of the point of a password hashing scheme, but slow unit tests are anathema.

We could make these tests (or the slower versions of them) off-by-default using the TT_OFF_BY_DEFAULT flag, I guess. But is that wise?

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by nickm

Keywords: 026-deferrable added

comment:2 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

comment:3 Changed 5 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.6.x-final

That's it, I'm sick of this. Fixed in 7322de15dc2f0858291f40df1a55a66c80b7fda9.

(Since it only touches the tests, I'm going to be bold and merge it.)

comment:4 Changed 5 years ago by nickm

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.