Transform code to cleaner c99 style

For #13233 (moved), we added a loose c99 requirement for building Tor. If we decide to keep it through the 0.2.6.x series, we can beautify our code a little.

changed milestone to %Tor: unspecified

added coccinelle component::core tor/tor milestone::Tor: unspecified priority::low severity::normal status::needs-information technical-debt tor-client type::defect labels

Trac:
Cc: N/A to mcs

Trac:
Cc: mcs to mcs, teor

Trac:
Milestone: Tor: 0.2.6.x-final to Tor: 0.2.???

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Milestone: Tor: 0.3.??? to Tor: unspecified
Keywords: N/A deleted, tor-03-unspecified-201612 added

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Reviewer: N/A to N/A
Priority: Medium to Low
Severity: N/A to Normal
Sponsor: N/A to N/A
Cc: mcs, teor to mcs, teor, ahf, catalyst
Keywords: N/A deleted, coccinelle, tor-client technical-debt added

We should probably figure out what we want to do here:

First two things I can think of:

• Convert functions that returns 0 or 1 to return bool (true/false) from <stdbool.h>?
• Lift for loop variables declarations into their loop initialiser?

Additionally, It might be interesting to figure out when/if we can start using C11 features?

Replying to ahf:

We should probably figure out what we want to do here:

First two things I can think of:

• Convert functions that returns 0 or 1 to return bool (true/false) from <stdbool.h>?

We also want to make the crypto API return 0 and 1 rather than 0 and -1. (I think there's a ticket for this already.) Then we could convert it to use bool as well.

• Lift for loop variables declarations into their loop initialiser?

Additionally, It might be interesting to figure out when/if we can start using C11 features?

When all supported compilers on all supported OSs support C11 (or whatever C11 features we want). Sometimes the Microsoft compilers are the slowest here.

Are there any particular features you have in mind?

It should be a C standard conformant code (C18 now) which can be compiled by any supported compiler (subset of C99 now). Right?

Trac:
Status: new to needs_information

moved to tpo/core/tor#13260 (closed)