Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#13285 closed defect (fixed)

Stop test & bench build failures with --disable-curve25519

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: curve25519 tor-relay
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Ensure test & bench code that references curve25519 is disabled by the appropriate macros. tor now builds with and without --disable-curve25519.

Version: tor-2.6.0-alpha
Origin: 47fab50cbaf3a41e8af9c63f645ad6075b43e565

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by teor

Status: newneeds_review

I've committed a fix to github at:

Branch: disable-curve25519-build-error
Repository: https://github.com/teor2345/tor.git
Commit: ffd92e8ef885f4a63fd09892d508674c9b4a1daf

tor (including test and bench) now builds and runs with and without --disable-curve25519.

comment:2 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks fine. Merged!

(So you know, changes that don't change anything since a released version don't need a changes/* file. Those are for things that will go in the changelog... but "we introduced a bug between versions, and then fixed it" is not usually changelog material.

comment:3 Changed 6 years ago by nickm

Milestone: Tor: 0.2.6.x-final
Note: See TracTickets for help on using tickets.