Opened 15 years ago

Last modified 8 years ago

#133 closed defect (Fixed)

descriptors have address until directory fetch

Reported by: goodell Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: goodell Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Descriptors received from the controller via the POSTDESCRIPTOR directive are interpreted to have address This is corrected at the time of the next periodic directory fetch, at which point the addr field of the routerinfo_t is populated with the correct address from the descriptor. Note that even if no descriptors with the same nickname or identity as the one received from the controller are received from the periodic directory fetch, the address of the descriptor received from the controller will apparently be changed to be the right one.

Indeed, this means that sending the HUP signal to the Tor process will always fix the problem, but ideally we should figure out why directory fetches are necessary to fix descriptors passed in from the controller.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (3)

comment:1 Changed 15 years ago by goodell

This patch appears to resolve the problem correctly. If router_resolve(ri) fails, we conclude that the node administrator both (a) set a hostname explicitly for the router and (b) resides in a DNS namespace that is not that of the Internet. In this unusual circumstance, the behavior of the system is the same as it was before the patch.

diff -u or/routerlist.c or.patch/routerlist.c
--- or/routerlist.c 2005-05-06 04:53:23.000000000 -0400
+++ or.patch/routerlist.c 2005-05-10 15:37:17.000000000 -0400
@@ -930,6 +930,10 @@


log_fn(LOG_DEBUG, "Added router to list");

+ /* Attempt to resolve the address of this router. */
+ router_resolve(ri);

return 1;



comment:2 Changed 15 years ago by nickm

flyspray2trac: bug closed.

This does, however, have worrisome anonymity implications. Hmn.

comment:3 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.