Opened 5 years ago

Closed 5 years ago

#13301 closed defect (fixed)

Update from 4.0-alpha-2 to 4.0-alpha-3 told me all my extensions were incompatible

Reported by: arma Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-firefox-patch, TorBrowserTeam201410, MikePerry2014010R, tbb-4.5-alpha
Cc: brade, mikeperry, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

My TBB 4.0-alpha-2 (32-bit Linux) popped up a thing saying there was an update ready. I said 'ok get it'. A while later it popped up a window with the title "Software Update" which said that the following extensions were incompatible with this new version, and they would be disabled until they were fixed to be compatible: Torbutton, Tor Launcher, HTTPS Everywhere.

My network here is really crappy -- is it possible there's some "try to reach the thing to check compatibility, if you time out, assume they're not compatible" logic somewhere?

(I'm assuming that the extensions do indeed self-identify as being compatible with all TBB 4.x.)

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by mcs

Kathy Brade and I will investigate. It does not seem like the update service should need to do any checking over the network for those add-ons (each of those extensions is marked as compatible with Very Large browser versions).

Last edited 5 years ago by mcs (previous) (diff)

comment:2 Changed 5 years ago by arma

When I finished pulling down the update, and moved to it, everything went smoothly -- I am now in 4.0-alpha-3 with those extensions apparently working.

I wonder what caused it to warn me.

comment:3 Changed 5 years ago by dcf

I saw the same dialog as arma. Maybe somewhat related to #13247?

comment:4 in reply to:  3 Changed 5 years ago by mcs

Replying to dcf:

I saw the same dialog as arma. Maybe somewhat related to #13247?

Interesting idea. But I think the dialog arma saw is displayed before the update is downloaded and applied, so I am not sure if #13247 would be related.

comment:5 Changed 5 years ago by mcs

Kathy Brade and I found some time today to investigate (and reproduce) this bug.
Unfortunately, the "Your add-ons are incompatible" prompt is not the result of a network glitch; it may occur for everyone who updates via the automatic prompt. If it is not too late, it would be nice to fix this for the TB 4.0 release.

comment:6 Changed 5 years ago by mcs

Cc: brade mikeperry gk added
Keywords: tbb-firefox-patch TorBrowserTeam201410 added
Owner: changed from tbb-team to mcs
Status: newassigned

comment:7 Changed 5 years ago by mcs

Keywords: MikePerry2014010R added
Status: assignedneeds_review

The fix is here:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/bc7f0127a2832ea6c9d7e72269404d9034793a92

Check in comment:

When updating via the background / timer-based check, the updater reported to
the user that some extensions were incompatible (not true).  The fix is to
check extension compatibility against the platformVersion in a few more places
(instead of against the appVersion, which is something like "4.0-alpha-3").

mikeperry and/or gk: Please review. Thanks!

comment:8 Changed 5 years ago by mikeperry

Keywords: tbb-4.5-alpha added

comment:9 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

This looks fine. Merged into the stable 4.x branch.

Note: See TracTickets for help on using tickets.