Oct 02 05:20:21.000 [warn] Unhandled OpenSSL errors found at ../src/or/buffers.c:819:
Oct 02 05:20:21.000 [warn] TLS error: block type is not 01 (in rsa routines:RSA_padding_check_PKCS1_type_1:---)
Oct 02 05:20:21.000 [warn] TLS error: padding check failed (in rsa routines:RSA_EAY_PUBLIC_DECRYPT:---)
Oct 02 05:20:21.000 [warn] TLS error: EVP lib (in asn1 encoding routines:ASN1_item_verify:---)
Trac: Username: torland
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Child items 0
Show closed items
No child items are currently assigned. Use child items to break down this issue into smaller parts.
Linked items 0
Link issues together to show that they're related.
Learn more.
The timing on this is interesting if we consider the recent libnss PKCS#1 signature validation issue. It seems reasonable to conclude that this OpenSSL code may have issues and that it should be inspected carefully.
Oct 02 06:30:38.000 [warn] Unexpected sendme cell from client. Closing circ (window 1000). [1 similar message(s) suppressed in last 600 seconds]
Oct 02 06:47:19.000 [warn] Unhandled OpenSSL errors found at ../src/or/buffers.c:819:
Oct 02 06:47:19.000 [warn] TLS error: block type is not 01 (in rsa routines:RSA_padding_check_PKCS1_type_1:---)
Oct 02 06:47:19.000 [warn] TLS error: padding check failed (in rsa routines:RSA_EAY_PUBLIC_DECRYPT:---)
Oct 02 06:47:19.000 [warn] TLS error: EVP lib (in asn1 encoding routines:ASN1_item_verify:---)
and
Oct 02 08:01:47.000 [warn] Unhandled OpenSSL errors found at ../src/or/buffers.c:748:
Oct 02 08:01:47.000 [warn] TLS error: block type is not 01 (in rsa routines:RSA_padding_check_PKCS1_type_1:---)
Oct 02 08:01:47.000 [warn] TLS error: padding check failed (in rsa routines:RSA_EAY_PUBLIC_DECRYPT:---)
Oct 02 08:01:47.000 [warn] TLS error: EVP lib (in asn1 encoding routines:ASN1_item_verify:---)
Unhandled errors are from failure of X509_verify called by tor_tls_cert_is_valid, from another tls context for another connection even that was already marked for close by channel_tls_process_certs_cell. Errors was handled by read_to_buf_tls because it called often, but could be handled on TLS handshake too. Openssl error queue unique for thread, but not for context.
To fix this situation in general we need:
Handle TLS errors after X509_verify and another possible friends.
To check if call of tls_log_errors need at the end of tls functions, in the name of
/* This should never get invoked, but let's make sure in case OpenSSL * acts unexpectedly. */
To check if every TLS IO operation protected by check_no_tls_errors. as example tor_tls_renegotiate need such check for sure.
Oct 02 04:30:09.000 [warn] Unhandled OpenSSL errors found at src/or/buffers.c:819:Oct 02 04:30:09.000 [warn] TLS error: block type is not 01 (in rsa routines:RSA_padding_check_PKCS1_type_1:---)Oct 02 04:30:09.000 [warn] TLS error: padding check failed (in rsa routines:RSA_EAY_PUBLIC_DECRYPT:---)Oct 02 04:30:09.000 [warn] TLS error: EVP lib (in asn1 encoding routines:ASN1_item_verify:---)
Oct 2 04:08:17 Tor[3081]: Unhandled OpenSSL errors found at ../src/or/buffers.c:748:Oct 2 04:08:17 Tor[3081]: TLS error: block type is not 01 (in rsa routines:RSA_padding_check_PKCS1_type_1:---)Oct 2 04:08:17 Tor[3081]: TLS error: padding check failed (in rsa routines:RSA_EAY_PUBLIC_DECRYPT:---)Oct 2 04:08:17 Tor[3081]: TLS error: EVP lib (in asn1 encoding routines:ASN1_item_verify:---)
Nov 26 03:39:39.000 [notice] Heartbeat: Tor's uptime is 9 days 12:00 hours, with 26156 circuits open. I've sent 13376.97 GB and received 12909.09 GB.Nov 26 03:39:39.000 [notice] Average packaged cell fullness: 99.294%Nov 26 03:39:39.000 [notice] TLS write overhead: 3%Nov 26 03:39:39.000 [notice] Circuit handshake stats since last time: 640620/640621 TAP, 379406/379406 NTor.Nov 26 06:27:21.000 [warn] Unhandled OpenSSL errors found at src/or/buffers.c:981: Nov 26 06:27:21.000 [warn] TLS error: block type is not 01 (in rsa routines:RSA_padding_check_PKCS1_type_1:---)Nov 26 06:27:21.000 [warn] TLS error: padding check failed (in rsa routines:RSA_EAY_PUBLIC_DECRYPT:---)Nov 26 06:27:21.000 [warn] TLS error: EVP lib (in asn1 encoding routines:ASN1_item_verify:---)Nov 26 09:39:39.000 [notice] Heartbeat: Tor's uptime is 9 days 18:00 hours, with 32744 circuits open. I've sent 13758.49 GB and received 13277.18 GB
Tor version 0.2.6.1-alpha (git-5a601dd2901644a5).
Happened only once though with the uptime being 42 days now.
I'm merging my branch, since it's not gotten any review or testing besides me, and I don't know if it will. More importantly, its only likely failure mode is the possibility of logging too loudly, which is easy to detect and fix.
Putting this in "needs_information": the information needed is, did the bug get fixed?
Trac: Milestone: Tor: 0.2.6.x-final to Tor: 0.2.??? Status: needs_review to needs_information