Opened 3 years ago

Closed 2 years ago

#13351 closed defect (fixed)

source on github differs from source on torproject

Reported by: gadelat Owned by: zyan
Priority: Medium Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

File src/chrome/content/rules/PHP.xml in master branch is different on github and torproject servers. There is bug in this file on second server, while it is not present on github. I thought they should be identical. It confused me for a moment when I was trying to contribute.

$ diff https-everywhere-torproject/src/chrome/content/rules/PHP.xml https-everywhere-github/src/chrome/content/rules/PHP.xml
69a70,73

<!-- Not secured by server:

-->

<!--securecookie host="bugs\.php\.net$" name="PHPSESSID$" /-->

74c78
< to="https://$1hp.net/" />
---

to="https://$1php.net/" />

Child Tickets

Change History (1)

comment:1 Changed 2 years ago by jsha

Resolution: fixed
Status: newclosed

Thanks for pointing this out! There was a gap when I didn't have push access to the Tor servers, now resolved.

Note: See TracTickets for help on using tickets.