Opened 3 years ago

Closed 26 hours ago

#13354 closed enhancement (fixed)

Switch to another set of country flags that has the right color for the French flag

Reported by: goose Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords: metrics-2017
Cc: sebastian@…, hellais Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The blue color used in the french flag is to bright. It should be a dark blue.

Child Tickets

Attachments (1)

fr.png (467 bytes) - added by goose 3 years ago.

Download all attachments as: .zip

Change History (28)

comment:1 Changed 3 years ago by goose

Cc: sebastian@… added

Changed 3 years ago by goose

Attachment: fr.png added

comment:2 Changed 3 years ago by goose

I attached a fixed version of the flag.

comment:3 Changed 3 years ago by goose

Type: defectenhancement

comment:4 Changed 3 years ago by phw

Owner: phw deleted
Status: newassigned

comment:5 Changed 3 years ago by phw

Status: assignednew

comment:6 Changed 3 years ago by goose

Type: enhancementdefect

comment:7 Changed 13 months ago by irl

Severity: Normal
Status: newneeds_review

This looks good to me.

comment:8 Changed 13 months ago by karsten

Cc: hellais added

irl: In theory I agree that the attached flag looks better. But I'd be wary of fixing them manually, because then we might see more requests to tweak flags in the future up to political discussions of which is the right flag for a given country. We had a similar situation with country names, and we ended up writing a script to fetch country names from the English Wikipedia and using them without further modifications. In this case I wonder if we should rely on the original source of country flags and decline making any changes. And maybe there's already an update to that upstream source for the blue color in the French flag. And if not, maybe we can ask them to update the French flag and use it once they have accepted it.

hellais: Where did you get the original country flags from?

goose: Where did you find that French flag, or did you edit that by hand?

comment:9 Changed 13 months ago by irl

I wasn't able to track down the original source of the flags, but yes, fixing it upstream and updating them from that would be great.

comment:10 Changed 11 months ago by karsten

Status: needs_reviewneeds_information

This ticket currently does not need review but is blocking on information from hellais and goose.

comment:11 Changed 11 months ago by karsten

Status: needs_informationnew

Alright, I found the country flags used by Atlas on the web. The French flag there has the same bright blue. And the most recent blog entry on that website is from 2006. I'd say there's no way to get a fresh set of country flags from upstream.

We could switch to another flag set. Suggestions?

comment:12 Changed 10 months ago by goose

The color seems to be right and the download is for free:

http://flagpedia.net/download

comment:13 Changed 10 months ago by irl

goose: That site doesn't seem to have a free license on it. ):

What do you think of these?

https://github.com/lipis/flag-icon-css/tree/master/flags/4x3

These seem to have an MIT license, so we can work with these. I haven't checked yet if there are missing flags, but the last commit was 2 weeks ago and I think these are actively maintained.

comment:14 Changed 10 months ago by goose

I wasn't sure about their license.The collection you found is looking good, couldn't find any missing flags.The French flag seems to be fine.Go for it :-)

comment:15 Changed 10 months ago by karsten

irl, that collection you found looks great! I'd say let's switch to that one.

comment:16 Changed 7 months ago by irl

Resolution: wontfix
Status: newclosed

Using SVG flags will break on Tor Browser with high security setting. I don't think we want to get into the game of maintaining flag images or deciding which country codes get which flags. We may revisit this again in the future but for now, this is a bug we will live with.

comment:17 Changed 7 months ago by goose

So it's just out of the question to use a differrent format ? It is not a game if i want my home country flag to be right and we do not decide about the right country flag when the current version is just wrong as you can see:

https://en.wikipedia.org/wiki/France
http://www.gouvernement.fr/

Why do i get the impression that it would be a different story if let's say there was an issue with the US flag as an example ? And "may revisit this again in the future" sounds to me like "it's just France, be quiet and i want to close the ticket no matter what"

comment:18 Changed 7 months ago by cypherpunks

This ticket is somewhat related to #19538 which contains another explanation on why both tickets were closed. I think we can do better than closing this ticket as wontfix.

  1. Convert the proposed SVGs to PNGs which is the easiest solution and doesn't break any use cases.
  2. Use the proposed SVGs which breaks with Tor Browser on security level High. I'd have to test this solution but i think breaking in this context means the flags aren't shown but the alternative text (aka the country name) is so no information is lost.
Last edited 7 months ago by cypherpunks (previous) (diff)

comment:19 Changed 7 months ago by karsten

Resolution: wontfix
Status: closedreopened

goose and cypherpunks, I'm with irl regarding not wanting to maintain flag images manually and I also understand the desire to close tickets that have stalled. But I also see how you're disappointed with the current French flag. Maybe we can find a compromise: we pick a maintained set of SVG flags and write a script to convert them to PNG. Hint: this might work faster if somebody submits a patch for that script.

comment:20 Changed 7 months ago by hellais

Is the french flag (https://github.com/gosquared/flags/blob/master/src/flags/France/64.png) in this set of flag better: https://github.com/gosquared/flags?

Those are available in png version too in various sizes.

It seems fairly well maintained and used by other projects as well (https://github.com/wiredmax/react-flags).

comment:21 Changed 7 months ago by goose

Yes, the color is right

comment:22 Changed 2 months ago by karsten

Owner: set to irl
Status: reopenedassigned
Summary: Wrong color in french flagSwitch to another set of country flags that has the right color for the French flag
Type: defectenhancement

Updating the summary to make it clearer what needs to be done here. Also turning into an enhancement and assigning to "the Atlas guy". :)

comment:23 Changed 8 weeks ago by karsten

Keywords: metrics-2018 added

comment:24 Changed 8 weeks ago by karsten

Keywords: metrics-2017 added; metrics-2018 removed

comment:25 Changed 9 days ago by irl

Moving this into my queue.

comment:26 Changed 8 days ago by irl

Status: assignedaccepted

comment:27 Changed 26 hours ago by irl

Resolution: fixed
Status: acceptedclosed

Fixed in 9bf8c7c862db0071c98ca2cd89950d3e1ddfb0c1.

Note: See TracTickets for help on using tickets.