Changes between Initial Version and Version 1 of Ticket #13443, comment 45


Ignore:
Timestamp:
Oct 30, 2014, 4:51:13 PM (5 years ago)
Author:
cypherpunks
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13443, comment 45

    initial v1  
    1 If to change uuids for [https://mxr.mozilla.org/mozilla-esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BaseFilter.h#158 BaseFilter] and for [https://mxr.mozilla.org/mozilla-esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.h#205 BasePin] to IID_IUnknown, like tested with binary patching:
    2 {{{
    3 Comparing files xul.dll and xul_patch.dll
    4 01EC9880: 54 00
    5 01EC9881: D3 00
    6 01EC9882: EB 00
    7 01EC9883: 4D 00
    8 01EC9884: C6 00
    9 01EC9885: B0 00
    10 01EC9886: AB 00
    11 01EC9887: 44 00
    12 01EC9888: 93 C0
    13 01EC9889: CF 00
    14 01EC988A: 49 00
    15 01EC988B: F6 00
    16 01EC988C: 4E 00
    17 01EC988D: D3 00
    18 01EC988E: 6A 00
    19 01EC988F: B8 46
    20 01EC9890: C6 00
    21 01EC9891: 69 00
    22 01EC9892: 96 00
    23 01EC9893: 19 00
    24 01EC9894: 2A 00
    25 01EC9895: 67 00
    26 01EC9896: 30 00
    27 01EC9897: 41 00
    28 01EC9898: B1 C0
    29 01EC9899: 3E 00
    30 01EC989A: 57 00
    31 01EC989B: AA 00
    32 01EC989C: 83 00
    33 01EC989D: 0E 00
    34 01EC989E: AE 00
    35 01EC989F: 55 46
    36 }}}
    37 Then QueryInterface for [https://mxr.mozilla.org/mozilla-esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BaseFilter.cpp#186 BaseFilter] [https://mxr.mozilla.org/mozilla-esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp#181 BasePin] returns proper interface instead of E_NOINTERFACE and no crash happens.
    38 
    39 MSVC generated code never calls QueryInterface for mentioned uuids.
     1Nothing