Opened 4 years ago

Last modified 4 weeks ago

#13469 reopened defect

Windows installer is missing many languages from the NSIS file

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: l10n
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The installer file lists 56 languages,

but the installer only shows 26.

It looks like these are the 30 languages that are missing, notably including TBB official languages Arabic, Farsi, Korean, Polish, Russian, Turkish, and Chinese.

  !insertmacro MUI_LANGUAGE "SimpChinese"
  !insertmacro MUI_LANGUAGE "TradChinese"
  !insertmacro MUI_LANGUAGE "Japanese"
  !insertmacro MUI_LANGUAGE "Korean"
  !insertmacro MUI_LANGUAGE "Greek"
  !insertmacro MUI_LANGUAGE "Russian"
  !insertmacro MUI_LANGUAGE "Polish"
  !insertmacro MUI_LANGUAGE "Ukrainian"
  !insertmacro MUI_LANGUAGE "Czech"
  !insertmacro MUI_LANGUAGE "Slovak"
  !insertmacro MUI_LANGUAGE "Croatian"
  !insertmacro MUI_LANGUAGE "Bulgarian"
  !insertmacro MUI_LANGUAGE "Hungarian"
  !insertmacro MUI_LANGUAGE "Thai"
  !insertmacro MUI_LANGUAGE "Romanian"
  !insertmacro MUI_LANGUAGE "Latvian"
  !insertmacro MUI_LANGUAGE "Macedonian"
  !insertmacro MUI_LANGUAGE "Estonian"
  !insertmacro MUI_LANGUAGE "Turkish"
  !insertmacro MUI_LANGUAGE "Lithuanian"
  !insertmacro MUI_LANGUAGE "Slovenian"
  !insertmacro MUI_LANGUAGE "Serbian"
  !insertmacro MUI_LANGUAGE "SerbianLatin"
  !insertmacro MUI_LANGUAGE "Arabic"
  !insertmacro MUI_LANGUAGE "Farsi"
  !insertmacro MUI_LANGUAGE "Hebrew"
  !insertmacro MUI_LANGUAGE "Mongolian"
  !insertmacro MUI_LANGUAGE "Albanian"
  !insertmacro MUI_LANGUAGE "Belarusian"
  !insertmacro MUI_LANGUAGE "Bosnian"

Child Tickets

Attachments (3)

tbb-windows-installer-langs.png (24.6 KB) - added by dcf 4 years ago.
How the language list appears in TBB 4.0 on Windows 8.
tbb-windows-installer-langs-alllanguages.png (26.7 KB) - added by dcf 4 years ago.
How language selection looks when you set MUI_LANGDLL_ALLLANGUAGES.
tbb-windows-installer-langs-alllanguages-zh_CN.png (10.9 KB) - added by dcf 4 years ago.
The installer after selecting simplified Chinese.

Download all attachments as: .zip

Change History (13)

Changed 4 years ago by dcf

How the language list appears in TBB 4.0 on Windows 8.

comment:1 Changed 4 years ago by dcf

Here's how it looks in TBB 4.0 on Windows 8.

How the language list appears in TBB 4.0 on Windows 8.

comment:2 Changed 4 years ago by dcf

I haven't tried it, but http://nsis.sourceforge.net/Examples/Modern%20UI/MultiLanguage.nsi has these lines:

  ;Properly display all languages (Installer will not work on Windows 95, 98 or ME!)
  Unicode true

My guess is that the languages that aren't displayed, are not displayed because their names aren't expressible in windows-1252. Maybe the Unicode setting will fix it.

Last edited 4 years ago by dcf (previous) (diff)

comment:3 in reply to:  2 ; Changed 4 years ago by dcf

Replying to dcf:

I haven't tried it, but http://nsis.sourceforge.net/Examples/Modern%20UI/MultiLanguage.nsi has these lines:

  ;Properly display all languages (Installer will not work on Windows 95, 98 or ME!)
  Unicode true

My guess is that the languages that aren't displayed, are not displayed because their names aren't expressible in windows-1252. Maybe the Unicode setting will fix it.

Nope, it doesn't like that:

Processing script file: "torbrowser.nsi"
!include: "/usr/share/nsis/Include/MUI2.nsh"
!include: "/usr/share/nsis/Contrib/Modern UI 2/MUI2.nsh"
NSIS Modern User Interface version 2.0 - Copyright 2002-2009 Joost Verburg (/usr/share/nsis/Contrib/Modern UI 2/MUI2.nsh:8)
!define: "MUI_INCLUDED"=""
!define: "MUI_SYSVERSION"="2.0"
!define: "MUI_VERBOSE"="3"
!include: closed: "/usr/share/nsis/Contrib/Modern UI 2/MUI2.nsh"
!include: closed: "/usr/share/nsis/Include/MUI2.nsh"
Invalid command: Unicode
Error in script "torbrowser.nsi" on line 13 -- aborting creation process

Maybe it needs a different NSIS. THe version installed inside the build VM is 2.46-7, which is current according to http://nsis.sourceforge.net/Main_Page. That page also links to something called Unicode NSIS.

Changed 4 years ago by dcf

How language selection looks when you set MUI_LANGDLL_ALLLANGUAGES.

Changed 4 years ago by dcf

The installer after selecting simplified Chinese.

comment:5 in reply to:  4 Changed 4 years ago by dcf

Replying to dcf:

http://nsis.sourceforge.net/Why_does_the_language_selection_dialog_hide_some_languages suggests

!define MUI_LANGDLL_ALLLANGUAGES

MUI_LANGDLL_ALLLANGUAGES makes the languages appear in the dropdown, but then the rendering of non-windows-1252 scripts is mojibake.

How language selection looks when you set MUI_LANGDLL_ALLLANGUAGES.

This is simplified Chinese:

The installer after selecting simplified Chinese.

comment:6 in reply to:  3 Changed 4 years ago by dcf

Replying to dcf:

Replying to dcf:

I haven't tried it, but http://nsis.sourceforge.net/Examples/Modern%20UI/MultiLanguage.nsi has these lines:

  ;Properly display all languages (Installer will not work on Windows 95, 98 or ME!)
  Unicode true

My guess is that the languages that aren't displayed, are not displayed because their names aren't expressible in windows-1252. Maybe the Unicode setting will fix it.

Nope, it doesn't like that:

Processing script file: "torbrowser.nsi"
!include: "/usr/share/nsis/Include/MUI2.nsh"
!include: "/usr/share/nsis/Contrib/Modern UI 2/MUI2.nsh"
NSIS Modern User Interface version 2.0 - Copyright 2002-2009 Joost Verburg (/usr/share/nsis/Contrib/Modern UI 2/MUI2.nsh:8)
!define: "MUI_INCLUDED"=""
!define: "MUI_SYSVERSION"="2.0"
!define: "MUI_VERBOSE"="3"
!include: closed: "/usr/share/nsis/Contrib/Modern UI 2/MUI2.nsh"
!include: closed: "/usr/share/nsis/Include/MUI2.nsh"
Invalid command: Unicode
Error in script "torbrowser.nsi" on line 13 -- aborting creation process

Maybe it needs a different NSIS. THe version installed inside the build VM is 2.46-7, which is current according to http://nsis.sourceforge.net/Main_Page. That page also links to something called Unicode NSIS.

It looks like it requires a newer NSIS than is packaged with Ubuntu.

1.4 Unicode installers
Starting with MakeNSIS v3.0 you can choose to create Unicode installers by setting the Unicode attribute.

http://sourceforge.net/projects/nsis/files/NSIS%203%20Pre-release/ has files, including version 3.0b1 released 2014-10-07. However only version 2.46 (released 2010-04-18) appears to be available in Ubuntu.

comment:7 Changed 2 years ago by bugzilla

Severity: Normal

torbrowser-install-6.5a2_en-US.exe has 12 langs only.

MUI_LANGDLL_ALLLANGUAGES makes the languages appear in the dropdown, but then the rendering of non-windows-1252 scripts is mojibake.

You need to install the appropriate language pack and set the Current language for non-Unicode programs to which you want to test. That is how the MUI works.

comment:8 Changed 5 weeks ago by dcf

Keywords: l10n added

comment:9 Changed 5 weeks ago by gk

Resolution: fixed
Status: newclosed

Fixed in 8.0a9, all languages are visible now.

comment:10 Changed 4 weeks ago by fixtbb

Resolution: fixed
Status: closedreopened

It seems fixed for win64 installer, but not for win32 (Tested with en_US 8.0a10).

Note: See TracTickets for help on using tickets.