Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#1355 closed defect (duplicate)

Tor doesn't build with warnings when using zlib 1.2.4

Reported by: Sebastian Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.2.1.25
Severity: Keywords: tor-client
Cc: Sebastian Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The latest version of zlib doesn't build cleanly with -Wundef -Werror.

In file included from torgzip.c:19:
/zlib/include/zlib.h:1568:32: error: "_FILE_OFFSET_BITS" is not defined

I've contacted the zlib authors about this, but haven't received a
response yet (and I think it might be unlikely to get a response, given
that they state that they ignore compile warnings in their FAQ).

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (5)

comment:1 Changed 9 years ago by Sebastian

Just received a reply from the zlib maintainers. They'll fix the compile warning
in their next release. I guess that means no work for us?

comment:2 Changed 9 years ago by nickm

Hm. Except that it would be nice if people could build Tor with zlib 1.2.4 without having to turn off
--enable-gcc-warnings .

Only one file includes zlib.h; maybe we could get our build system to not pass -Wundef to that one.

comment:3 Changed 9 years ago by nickm

Resolution: Noneduplicate
Status: newclosed

Closing as duplicate of bug #1526, since we've done more discussion with that name.

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.