Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

User reported about Tor Browser crash if they trying to change the download folder using Tools->Options->General(tab)

It's reproducible for WinXP. Windows reports:

Faulting application firefox.exe version 31.2.0.0
faulting module shlwapi.dll version 6.0.2900.2180
fault address 0x00006550.

WinXP is EOL, marking priority bug as minor for now or close it instead?

added MikePerry201411R component::applications/tor browser mingw-gcc owner::tbb-team priority::high resolution::fixed severity::normal status::closed tbb-4.5-alpha tbb-crash type::defect labels

Trac:
Summary: Tor Browser crashes (shlwapi.dll) on WinXP if try to change the download folder to Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

Trac:
Keywords: N/A deleted, tbb-crash added

Nothing

Nothing

Nothing

Nothing

Wow, I wonder why this is only affecting WinXP users. Is this codepath only run for WinXP users, I guess?

The fact that this bad code was generated at all may indicate that MinGW may be responsible for some or all of our other recent Windows crashes. We should notify the MinGW team of this issue.

Trac:
Priority: minor to major
Cc: N/A to gk

Nothing

https://bugzilla.mozilla.org/show_bug.cgi?id=1091594 is the Mozilla bug and Jacek is looking at it, too.

Could people affected by this test a build that should fix the problem and report back?

https://people.torproject.org/~gk/misc/torbrowser-install-4.0.1_en-US.exe https://people.torproject.org/~gk/misc/torbrowser-install-4.0.1_en-US.exe.asc

Nothing

Error signature AppName: firefox.exe AppVer: 31.2.0.0 ModName: shlwapi.dll ModVer: 6.0.2900.5912 Offset: 00006680

Georg Koppen's binary release, tested on XP SP3 -- same crash result.

​https://bugzilla.mozilla.org/show_bug.cgi?id=1091594 is the Mozilla bug

Status: RESOLVED FIXED Did they test with new patch for explicit casts to different integer types or what?

If they fixed then why no backport fix to 31? If they thinks it's not mozilla bug then why not to write about it? Can you explain what purpose to base Tor Browser on code that never built and tested with open source software. You should to drop firefox, lets them to compile it with VC alone.

Trac:
Priority: major to blocker
Summary: Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder to Drop Firefox

This is the wrong place to rant about Firefox.

Trac:
Priority: blocker to major
Summary: Drop Firefox to or Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

Trac:
Summary: or Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder to Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

This is the wrong place to rant about Firefox.

Where is right place?

Compiling ESR 24 we use in 3.6.6 with the compiler we use for 4.0 leads to no crash.

Nothing

Trac:
Username: cypherpunks_backup

bug_13558 in my public tor-browser repo should have a fix for this issue. I tested it with a modified build on a Windows 7 machine and both without a patch and with Jacek's first patch the Tor Browser was crashing on changing the download folder while that was not the case anymore with the patch that landed on mozilla-central.

Trac:
Status: new to needs_review
Keywords: N/A deleted, MikePerry201411R added

A test build with the proposed fix is

https://people.torproject.org/~gk/misc/torbrowser-install-4.0.1_en-US-13558.exe https://people.torproject.org/~gk/misc/torbrowser-install-4.0.1_en-US-13558.exe.asc

Ok, I merged this into tor-browser-31.2.0esr-4.5-1 so we also have it in the nightly and 4.5-alpha-1.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed
Keywords: N/A deleted, tbb-4.5-alpha added

Trac:
Severity: N/A to Normal
Sponsor: N/A to N/A
Keywords: N/A deleted, mingw-gcc added

closed

mentioned in issue #13654 (moved)

moved to tpo/applications/tor-browser#13558 (closed)

mentioned in issue tpo/applications/tor-browser#13654 (closed)