Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#13558 closed defect (fixed)

Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

Reported by: cypherpunks Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-crash, MikePerry201411R, tbb-4.5-alpha, mingw-gcc
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

User reported about Tor Browser crash if they trying to change the download folder using Tools->Options->General(tab)

It's reproducible for WinXP. Windows reports:

Faulting application firefox.exe version 31.2.0.0
faulting module shlwapi.dll version 6.0.2900.2180
fault address 0x00006550.

WinXP is EOL, marking priority bug as minor for now or close it instead?

Child Tickets

Change History (25)

comment:1 Changed 4 years ago by cypherpunks

Summary: Tor Browser crashes (shlwapi.dll) on WinXP if try to change the download folderTor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

comment:2 Changed 4 years ago by cypherpunks

Keywords: tbb-crash added

comment:3 Changed 4 years ago by cypherpunks

Nothing

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:4 Changed 4 years ago by cypherpunks

Nothing

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:5 Changed 4 years ago by cypherpunks

Nothing

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:6 Changed 4 years ago by cypherpunks

Nothing

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:7 Changed 4 years ago by mikeperry

Cc: gk added
Priority: minormajor

Wow, I wonder why this is only affecting WinXP users. Is this codepath only run for WinXP users, I guess?

The fact that this bad code was generated at all may indicate that MinGW may be responsible for some or all of our other recent Windows crashes. We should notify the MinGW team of this issue.

comment:8 Changed 4 years ago by cypherpunks

Nothing

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:9 Changed 4 years ago by gk

https://bugzilla.mozilla.org/show_bug.cgi?id=1091594 is the Mozilla bug and Jacek is looking at it, too.

comment:11 Changed 4 years ago by cypherpunks

Nothing

Last edited 4 years ago by cypherpunks (previous) (diff)

comment:12 Changed 4 years ago by cypherpunks

Error signature
AppName: firefox.exe
AppVer: 31.2.0.0
ModName: shlwapi.dll
ModVer: 6.0.2900.5912
Offset: 00006680

Georg Koppen's binary release, tested on XP SP3 -- same crash result.

comment:13 Changed 4 years ago by cypherpunks

https://bugzilla.mozilla.org/show_bug.cgi?id=1091594 is the Mozilla bug

Status: RESOLVED FIXED
Did they test with new patch for explicit casts to different integer types or what?

comment:14 Changed 4 years ago by cypherpunks

If they fixed then why no backport fix to 31? If they thinks it's not mozilla bug then why not to write about it?
Can you explain what purpose to base Tor Browser on code that never built and tested with open source software. You should to drop firefox, lets them to compile it with VC alone.

comment:15 Changed 4 years ago by cypherpunks

Priority: majorblocker
Summary: Tor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folderDrop Firefox

comment:16 Changed 4 years ago by gk

Priority: blockermajor
Summary: Drop Firefoxor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

This is the wrong place to rant about Firefox.

comment:17 Changed 4 years ago by gk

Summary: or Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folderTor Browser 4.0 crashes (shlwapi.dll) on WinXP if try to change the download folder

comment:18 Changed 4 years ago by cypherpunks

This is the wrong place to rant about Firefox.

Where is right place?

comment:19 Changed 4 years ago by gk

Compiling ESR 24 we use in 3.6.6 with the compiler we use for 4.0 leads to no crash.

comment:20 in reply to:  19 Changed 4 years ago by cypherpunks_backup

Nothing

Last edited 4 years ago by cypherpunks_backup (previous) (diff)

comment:21 Changed 4 years ago by gk

Keywords: MikePerry201411R added
Status: newneeds_review

bug_13558 in my public tor-browser repo should have a fix for this issue. I tested it with a modified build on a Windows 7 machine and both without a patch and with Jacek's first patch the Tor Browser was crashing on changing the download folder while that was not the case anymore with the patch that landed on mozilla-central.

comment:23 Changed 4 years ago by mikeperry

Ok, I merged this into tor-browser-31.2.0esr-4.5-1 so we also have it in the nightly and 4.5-alpha-1.

comment:24 Changed 4 years ago by gk

Keywords: tbb-4.5-alpha added
Resolution: fixed
Status: needs_reviewclosed

comment:25 Changed 3 years ago by cypherpunks

Keywords: mingw-gcc added
Severity: Normal
Note: See TracTickets for help on using tickets.