Opened 5 years ago

Last modified 3 years ago

#13592 new defect

Tor Browser Bundle 4.0 Linux - Doesn't Theme

Reported by: torrified Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

My specs;

Slackware 14.1 x86_64
gtk+3-3.8.2
qt-4.8.5
qt5-5.3.2
TBB 4.0 Linux x64

I don't remember if TBB is compiled against GTK or QT?

All of TBB doesn't show any themeing, from the startup window(s) to the browser itself.

I'm attaching a screen shot you can see showing no theming, just like the browser...

Child Tickets

Attachments (2)

tbb6_linux_x64.jpg (201.2 KB) - added by torrified 5 years ago.
firefox.jpg (227.4 KB) - added by torrified 5 years ago.

Download all attachments as: .zip

Change History (17)

Changed 5 years ago by torrified

Attachment: tbb6_linux_x64.jpg added

Changed 5 years ago by torrified

Attachment: firefox.jpg added

comment:1 Changed 5 years ago by torrified

Both are always the same beige color, with the square button and square look to everything. Reminds me of 15 years ago, looking like some old tcl/tk or gtk1 gui apps, LOL...

This looks really dated... :(

comment:2 Changed 5 years ago by torrified

Has anyone had a chance to look at this?

I've been seeing this issue going all the way back to 2.x TBB from over a year ago...

comment:3 Changed 5 years ago by torrified

I remember reading in the past that 2x versions were using QT, so in qtconfig I have it set to GTK, which I'm now assumging it should use this and theme with one of my gtk themes, but it doesn't.

I also noticed in /Browser/.config/gtk-2.0 that there is no gtk-3.0, the tbb doesn't support GTK3?

comment:4 Changed 5 years ago by torrified

Hi,

Has anyone had a chance to see this?

Can this be fixed on the end-users side, something I can do to make it theme, or is this something that has to be fixed in the code?

I understand everyone is busy, but if someone could please let me know I'd greatly apprciate it!

thank you

comment:5 Changed 5 years ago by torrified

Hi,

Ijust wanted to report that I don't see any changes with 4.0.2, it still doesn't theme properly...

thank you

comment:6 Changed 5 years ago by torrified

4.0.3 still doesn't work, and I also noticed another problem in Linux.

Whatever mouse cursor theme I use, when I put my mouse somewhere on the browser it changes to the default looking black X11 cursor...

PLEASE Tor developers, no one has taken just a few moments of their time to give a reply back, can we PLEASE get this theming and mouse issue fixed?

thank you

comment:7 Changed 5 years ago by gk

I guess it would go faster if you could help debugging the issue and if you would even provide a fix for it.

comment:8 Changed 5 years ago by mcs

I looked around a little and it looks like GTK3 support is still a work in progress at Mozilla:
https://bugzilla.mozilla.org/show_bug.cgi?id=627699

I do not know anything about theme-ing on Linux, but an Internet search reveals that this is an ongoing issue for Firefox (and therefore for Tor Browser), e.g.,
https://duckduckgo.com/?q=firefox+gtk+theme

Some possibly useful info can be found here:
http://askubuntu.com/questions/337018/firefox-not-affected-by-gtk-theme

Maybe you can find a workaround and document it for other people.

comment:9 Changed 5 years ago by torrified

I'm using GTK themes that provide for GTK2 & GTK3...

I can help debug if someone tells me what to do?

This is not just a gtk3 issue...

Firefox works just fine with GTK2 & GTK3, I don't see this as just a Firefox issue, but somehow Tor has self contained the browser is my feeling, so it's not able to see the themes in the system and have access to them, because if the Tor Browser was working like any other application it would theme. And Tor is a self containted unit, meaning it just sits in it's own directory and isn't even installed into the system, that means the developers have to figure out how to have access to the system for theming.

comment:10 Changed 5 years ago by torrified

My understanding is that GTK or QT look for apps in /usr or /usr/local and if this is a portable applicaiton like Tor browser has been made into, then the developers are going to have to hack some files to gtk or qt, whichever theming they want to pick up Tor in any /path it's sitting...

Actually my bad, --prefix= can be any path /opt as example too...

Last edited 5 years ago by torrified (previous) (diff)

comment:11 Changed 5 years ago by torrified

Also let's PLEASE not FORGET the mouse also does not theme that I mentioned before, it always stays on the default X11 look, typical black cursor, maybe some distros name it differently, I'm not sure...

comment:12 Changed 5 years ago by torrified

OK I FOUND THE PROBLEM!

Shessh I really let this one slip by me, LOL...

Tor Browser is only looking at the themes in the /usr/share/themes /path it is not seeing themes the end-user might place in their $HOME under /home/user/.themes

Also the mouse cursor icons are only loading from /user/share/icons instead of being able to have them load as well from the end-users $HOME /path /home/user/.icons

I hope this is now an easy fix since I found the problem...

Last edited 5 years ago by torrified (previous) (diff)

comment:13 Changed 3 years ago by torrified

Severity: Normal

I described a fix in this new ticket I created;

https://trac.torproject.org/projects/tor/ticket/19708

Just create 3 files; start.sh - gtkrc-path - gtkrc

Also to make it self contained, include a theme and a mouse cursor icon and then have this information in the 3 files; (THE ONLY THING I'M NOT SURE ON, I FORGOT, IS HOW TO WRITE IT TO PICK THE USER USING THIS, UNLESS THAT CAN BE WRITTEN AS /home/$USER/)

start.sh
cd /home/foo/.tor-browser-linux64-6.0.2_en-US
./gtkrc-path

gtkrc-path
GTK2_RC_FILES=/home/foo/.tor-browser-linux64-6.0.2_en-US/gtkrc
/home/foo/.tor-browser-linux64-6.0.2_en-US/start-tor-browser.desktop

gtkrc
# Set the Gtk theme
include "/home/foo/.themes/Numix/gtk-2.0/gtkrc"

# Set the icon theme
gtk-icon-theme-name=Numix

# Set the mouse cursor
gtk-cursor-theme-name="redglass"

# Set the font
style "Newspaper"
{
font_name = "Newspaper 9"
}
widget_class "*" style "Newspaper"
gtk-font-name = "Newspaper 9"

Last edited 3 years ago by torrified (previous) (diff)

comment:14 Changed 3 years ago by cypherpunks

This bug should be closed as "wontfix". The GTK style is used for web page content rendering and can be used for fingerprinting. It affects the size of various GUI controls.

https://trac.torproject.org/projects/tor/ticket/18283

comment:15 Changed 3 years ago by torrified

@cypherpunks

Do you fully understand Fingerprint?

This is simply looking at the 'Differences' and seeing how you compare.

So if everyone using the Tor browser for Linux uses a default theme added to Tor, then there is no fingerprint issue, this only comes into play when you Stand Out from the Crowd!

ALSO you and the Tor team need to understand, or at least convey the understanding that you know about computer Security, Privacy & Anonymity, because talking about implementing something like this, or even a single person using this is ridiculous in those terms, and doesn't convey this understanding!

An experienced user, that applies security and privacy on their end doesn't need to worry about browser fingerprinting, it's utter nonsense!

So, again, Tor applying a theme for Tor Browser bundle that everyone on the planet is using, is not a fingerprinting issue!

Last edited 3 years ago by torrified (previous) (diff)
Note: See TracTickets for help on using tickets.