Changes between Version 1 and Version 2 of Ticket #13594, comment 12


Ignore:
Timestamp:
Oct 30, 2014, 4:57:11 PM (5 years ago)
Author:
cypherpunks
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13594, comment 12

    v1 v2  
    1 > and no ways to bypass it.
    2 
    3 It changes PATH environment variable.
    4 What for PATH in Tor Browser? What if to change [https://mxr.mozilla.org/mozilla-esr31/source/toolkit/xre/nsWindowsWMain.cpp#80 call of] SanitizeEnvironmentVariables (or directly [https://mxr.mozilla.org/mozilla-esr31/source/xpcom/base/nsSetDllDirectory.h#19 SanitizeEnvironmentVariables]), to clear PATH and to fill it by:
    5 1. The directory from which Tor Browser loaded.
    6 2. The system directory. Use the GetSystemDirectory function to get the path of this directory.
    7 3. The Windows directory. Use the GetWindowsDirectory function to get the path of this directory.
    8 It allows to protect against injected paths and fixes `updater.exe` without extra voodoo or copying of need dlls to need dir.
     1Nothing