Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13650 closed defect (fixed)

Better handle vertical displays

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-fingerprinting-resolution, tbb-4.5-alpha, MikePerry201503, TorBrowserTeam201503
Cc: mcs, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The width of the Tor browser window is capped at 1000 pixels, but the height can grow without bound. We also always return "portrait" for our screen orientation, as per #13025. We should decide a sane way to handle this.

In https://trac.torproject.org/projects/tor/ticket/13025#comment:17, gunes gave us some data on what the distribution looks like in the wild. We should use that data to find the best way to cap vertical resolution, and what to do with the orientation bit.

I am thinking the best answer is to cap the vertical resolution so that people with vertical displays don't actually appear to be in that orientation due to a huge vertical size, and continue to lie about orientation, but I am open to suggestions.

Child Tickets

Change History (11)

comment:1 Changed 4 years ago by mikeperry

Summary: Better handle verticle displaysBetter handle vertical displays

comment:2 Changed 4 years ago by mikeperry

Keywords: tbb-fingerprinting-resolution added; tbb-fingerprinting removed

comment:3 Changed 4 years ago by mikeperry

I marked #11439 as a dup of this.

comment:4 Changed 4 years ago by mikeperry

Keywords: tbb-4.5-alpha added

comment:5 Changed 4 years ago by mikeperry

Owner: changed from tbb-team to mikeperry
Status: newassigned

comment:6 Changed 4 years ago by mikeperry

Keywords: MikePerry201503 added

comment:7 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201503R added
Status: assignedneeds_review

I wrote a fix for this in mikeperry/bug13650: https://gitweb.torproject.org/mikeperry/torbutton.git/log/?h=bug13650.

I capped the maxHeight at 1000 by default, based on the data in https://trac.torproject.org/projects/tor/ticket/13025#comment:17. It appears that beyond 1000px, most monitors are vertical displays (also also relatively rare by comparison).

comment:8 Changed 4 years ago by gk

Sounds good to me. I am inclined to go with cappedWidth/cappedHeight and to not (try) to round that value, too. Was your reasoning for rounding that anyway that users might mess with these capped values and shoot themselves in the fool? I think this is negligible.

comment:9 in reply to:  7 Changed 4 years ago by mcs

Replying to mikeperry:

I wrote a fix for this in mikeperry/bug13650: https://gitweb.torproject.org/mikeperry/torbutton.git/log/?h=bug13650.

Kathy and I also reviewed this and it looks fine to us.

comment:10 Changed 4 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

OK. I merged this as-is. I think it is important to perform the rounding after application of this pref, especially since we already have two additional prefs to force the window to be the exact size the user wants.

comment:11 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201503 added; TorBrowserTeam201503R removed
Note: See TracTickets for help on using tickets.