Opened 6 years ago

Closed 6 years ago

#13651 closed defect (fixed)

tor-control-port.js freezes browser

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords:
Cc: gk, mikeperry, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


It turns out that by switching the socket to a fully nonblocking outputstream, we can stop this freezing. Mozilla's nonblocking outputstreams require the use of asyncWait; otherwise they frequently throw NS_BASE_STREAM_WOULD_BLOCK. Fix attached. See also #8642.

Child Tickets

Attachments (1)

0001-fixup-Bug-8641-TorButton-popup-menu-that-displays-cu.patch (5.4 KB) - added by arthuredelstein 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by arthuredelstein

Cc: gk mikeperry added

comment:2 Changed 6 years ago by mcs

Cc: mcs brade added

comment:3 Changed 6 years ago by cypherpunks

See also #8642.

Yet #9531 and #10804

comment:4 Changed 6 years ago by arthuredelstein

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.