Opened 4 years ago

Closed 3 years ago

#13661 closed defect (fixed)

Accept shorter version numbers

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay, 025-backport, nickm-patch
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I was thinking about removing the leading 0 from our version numbers, and realized that we can't[*] do that yet: tor_version_parse assumes that if you have a three-number version, you may not have a tag.

Let's allow two-number versions and three-number versions to have tags. And let's look into other ways to fix tor_version_parse.

[*] There are other ways to remove our leading 0. We could use four-number for alphas, and three-number versions for stable versions, as in "2.7.0.1-alpha, 2.7.0.2-alpha, 2.7.0.3-alpha, 2.7.0.4-rc, 2.7.5". Or we could have Tor report its vesion as 2.7.1-alpha to the UI, but advertise it as 0.2.7.1-alpha to other tors to work around this bug.

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by nickm

Status: newneeds_review

bug13661_025 has a revised tor_parse_version(), with tests.

comment:2 Changed 4 years ago by nickm

Keywords: nickm-patch added

Add the nickm-patch keyword to some needs_review tickets where I wrote or substantially revised the patch. This helps me find which tickets I should review and which I should find reviewers for.

comment:3 Changed 4 years ago by andrea

I think this one looks okay - yay killing repeated code with macros.

comment:4 Changed 4 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.5.x-final

Merged to master; marking for backport.

comment:5 Changed 3 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final
Resolution: fixed
Status: needs_reviewclosed

Not backporting these.

Note: See TracTickets for help on using tickets.