Opened 5 years ago

Closed 5 years ago

#13674 closed enhancement (implemented)

Remove advertised bandwidth and advertised bandwidth fraction graphs from weights document

Reported by: karsten Owned by:
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Keywords:
Cc: iwakeh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Onionoo's weights documents contain two graphs for advertised bandwidth and advertised bandwidth fraction that I'd like to get rid of.

The reason is very similar to the reason stated in #13673 for removing the "advertised_bandwidth_fraction" field from details documents: maintaining these graphs increases code complexity which leads to errors and makes it harder to implement new features. Further, initializing a new Onionoo instance from descriptor archives becomes prohibitively expensive with these two graphs.

It looks like both Atlas and Globe show the advertised bandwidth fraction graph, but not the advertised bandwidth graph. In both cases, taking out this graph and leaving in consensus weight fraction and guard/middle/exit probability wouldn't hurt user experience too much.

In fact, little-t-tor doesn't depend on (self-reported) advertised bandwidth for anything, because relays have been lying about that value in the past. So, we shouldn't display a graph with fractions if it's known that network totals may be inaccurate because of liars.

In the future, we might provide new bandwidth graphs for configured bandwidth rate and burst, observed bandwidth, and advertised bandwidth (but not fraction). Those can all be drawn from server descriptors without having to combining them with consensuses. Adding these graphs is not trivial and deserves a new ticket. I'm just mentioning this idea here, because it seems relevant.

I'll leave this ticket open for discussion until beginning of next week. If there are no convincing arguments for keeping these two graphs, I'll remove them. They're optional, so there's no need for a month-long heads-up here.

Child Tickets

Change History (2)

comment:1 Changed 5 years ago by iwakeh

Same as with #13673.
It's always good to clean up and remove obsolete stuff.

comment:2 Changed 5 years ago by karsten

Resolution: implemented
Status: newclosed

Agreed! Merged and deployed. Closing.

Note: See TracTickets for help on using tickets.