Opened 5 years ago

Closed 7 months ago

#13726 closed defect (worksforme)

A bunch of Pluggable Transport related .pyd files depend on msvcr90.dll which we do not ship

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm
Cc: dcf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are a bunch of .pyd files (namely _ctypes.pyd, _hashlib.pyd, _socket.pyd, _ssl.pyd, bz2.pyd, pyexpat.pyd, select.pyd and unicodedata.pyd) which directly depend on msvcr90.dll which we do not ship. We should get rid of that dependency if we don't need it.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by dcf

What is the effect of the dependency? Does it mean that the Python PTs don't run for some users? From what I remember of msvcr90.dll, it comes from having once installed the Visual C++ Redistributable package, so users wh ohave never installed any other software that requires it are affected.

I suppose it comes from us using the binary installer python.msi instead of building from source. The upstream Python is built with Visual C++, I believe. comment:18:ticket:9444 explains why the binary installer is used, namely, that Python isn't set up to support cross compiling. Or, it wasn't 12 months ago when we added pluggable transports to the bundle; maybe things have changed since then.

comment:2 in reply to:  1 Changed 5 years ago by gk

Replying to dcf:

What is the effect of the dependency? Does it mean that the Python PTs don't run for some users? From what I remember of msvcr90.dll, it comes from having once installed the Visual C++ Redistributable package, so users wh ohave never installed any other software that requires it are affected.

I have not heard any complains about that yet. Thus, there might be no visible effect at all. I just found that issue today while looking closer at the dependencies of the above mentioned files.

comment:3 Changed 2 years ago by gk

Keywords: tbb-rbm added; tbb-gitian removed
Severity: Blocker

comment:4 Changed 2 years ago by gk

Severity: BlockerNormal

comment:5 Changed 7 months ago by gk

Resolution: worksforme
Status: newclosed

This is a non-issue anymore with no PT for Windows based on Python.

Note: See TracTickets for help on using tickets.