Opened 5 years ago

Closed 4 years ago

#13745 closed defect (fixed)

Determine which patches to apply from wpapper's Globe fork

Reported by: isis Owned by: isis
Priority: High Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: karsten, Syrup-tan, isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by isis)

Karsten pointed out in an email that wpapper's fork of Globe on Github includes several important fixes.

Unfortunately, there's some weird merging stuff that they did, and it's not really possible to merge single branches without pulling in everything. We'll have to sort through the commits and figure out which ones we need and their issue tracker to figure out why, and then apply them to the official Globe repository,

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by isis

Description: modified (diff)

comment:2 Changed 5 years ago by isis

Status: newneeds_review

I picked through some of the commits to organise them into which commits solve which issue on the github tracker, and put them all in my trac-13745 branch. There are also trac-13745-wpapper-issue-* branches for each of the fork's issues, with related commits. I haven't tested this branch yet, and so it needs testing and probably review from someone else before it's merged to master.

comment:3 Changed 4 years ago by karsten

Component: Metrics/GlobeMetrics/Atlas
Severity: Normal
Status: needs_reviewneeds_information

We're shutting down Globe, so that these branches are unlikely to be merged anymore. But is there anything interesting in these branches that we could create Atlas tickets or even patches for? Changing to Atlas component just in case.

comment:4 Changed 4 years ago by irl

The original repository referenced in the ticket no longer appears to exist.

isis references her branch, but these only seem to contain bug fixes that would be relevant to Globe, not anything that is implementing new features.

Unless I'm missing something here, I believe this ticket can be closed.

comment:5 Changed 4 years ago by karsten

Resolution: fixed
Status: needs_informationclosed

irl, sounds good to me. Thanks for checking! Closing.

Note: See TracTickets for help on using tickets.