Validate is_canonical more thoroughly

We use is_canonical to tell whether we should extend a circuit over a channel... but we should also double-check it as we are extending that circuit, to make sure we didn't mess up.

Also, we should audit the code that sets is_canonical.

changed milestone to %Tor: unspecified

added component::core tor/tor milestone::Tor: unspecified points::1 priority::high security severity::normal sponsor::S-can status::new tor-relay tor-sponsorS-orphan type::enhancement version::tor 0.2.7 labels

@nickm, can you define "didn't mess up". I looked over it but can't really know what I'm looking for. Thanks!

The rule is approximately: we should only extend circuits on is_canonical channels.

Right now, we enforce this by checking is_canonical when we call channel_get_for_extend. But perhaps we should also check it when we do the circuit extend to make sure that the same check is still true.

Trac:
Milestone: Tor: 0.2.6.x-final to Tor: 0.2.7.x-final

Trac:
Status: new to assigned

Marking more tickets as triaged-in for 0.2.7

Trac:
Keywords: tor-relay security deleted, security, tor-relay, 027-triaged-1-in added

Trac:
Version: N/A to Tor: 0.2.7
Keywords: N/A deleted, SponsorS added
Points: N/A to small

Moving these tickets into 0.2.8. Not expecting to take patches for any into 0.2.7 at this late date. As usual, please say something if you disagree! :)

Trac:
Milestone: Tor: 0.2.7.x-final to Tor: 0.2.8.x-final

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

Trac:
Sponsor: N/A to SponsorS
Keywords: SponsorS deleted, N/A added

Turn most 0.2.8 "assigned" tickets with no owner into "new" tickets for 0.2.9. Disagree? Find somebody who can do it (maybe you?) and get them to take it on for 0.2.8. :)

Trac:
Status: assigned to new
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.9.x-final

Trac:
Sponsor: SponsorS to SponsorS-can

Trac:
Keywords: N/A deleted, tor-sponsorS-orphan added

Trac:
Points: small to 1

Trac:
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.???
Keywords: N/A deleted, isaremoved added

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Milestone: Tor: 0.3.??? to Tor: unspecified
Keywords: N/A deleted, tor-03-unspecified-201612 added

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: N/A deleted, 027-triaged-in added

Trac:
Keywords: 027-triaged-in deleted, N/A added

Trac:
Keywords: 027-triaged-1-in deleted, N/A added

Trac:
Keywords: isaremoved deleted, N/A added

Trac:
Reviewer: N/A to N/A
Priority: Medium to High
Severity: N/A to Normal

changed time estimate to 8h

moved to tpo/core/tor#13753 (closed)