Opened 3 years ago

Last modified 12 days ago

#13768 reopened defect

clean orbot build from git clone https://git.torproject.org/orbot.git

Reported by: throwaway1 Owned by: n8fr8
Priority: Medium Milestone:
Component: Applications/Orbot Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Trying to make clean build from

git clone https://git.torproject.org/orbot.git

It seems that makefile is not sync with latest external folders. iptables, libevent missing.
How are official builds made? It looks that not from clean start. Messy stuff.
As security app as is should be more proper maintained.


make[3]: Leaving directory `/media/verbatim/git/orbot_main/orbot/external/openssl/engines/ccgost'
make[2]: Leaving directory `/media/verbatim/git/orbot_main/orbot/external/openssl/engines'
make[1]: Leaving directory `/media/verbatim/git/orbot_main/orbot/external/openssl'
touch openssl-build-stamp

test -d lib test -d include test -d include/openssl
mkdir lib
mkdir include
mkdir include/openssl

cp openssl/libcrypto.a lib/libcrypto.a
cp openssl/libssl.a lib/libssl.a
cp openssl/include/openssl/* include/openssl
sed -i 's@\(SUBDIRS = . include\) sample test@\1@' libevent/Makefile.am
sed: can't read libevent/Makefile.am: No such file or directory
make: [libevent/Makefile] Error 2
make: Leaving directory `/media/verbatim/git/orbot_main/orbot/external'

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by n8fr8

Resolution: not a bug
Status: newclosed

You might want to RTFM before criticizing my work here:
https://gitweb.torproject.org/orbot.git/blob/HEAD:/BUILD

and learn how to use git:

git submodule update --init --recursive

This will pull all the external dependencies you are looking for from their source repos, pegged to the proper commit.

As for your comment on messy and proper, we have implemented continuous integration, with automated tests that run on a multi-device test cloud, and we have a hardened offline build machine for signed releases.

comment:2 Changed 3 years ago by throwaway1

:) You skip one question

How are official builds made? It looks that not from clean start....

https://gitweb.torproject.org/orbot.git/commitdiff/c013c071eb158ff756021dc89553ea7ee0dd8590

So without error skips ones that are not in git. In my case first that makes error is libevent.
After 3 months I am first with this kind of problems?

I'm really no expert in git so I wonder how this git submodules works. Takes latest from master? :( Where you can specify branch, tag... Must look more at it.

comment:3 Changed 3 years ago by throwaway1

Resolution: not a bug
Status: closedreopened

comment:4 Changed 3 years ago by blanu

I have also encountered this problem.

As mentioned, the commit ​https://gitweb.torproject.org/orbot.git/commitdiff/c013c071eb158ff756021dc89553ea7ee0dd8590 removed the libevent submodule.

As libevent is required, make now fails.

comment:5 Changed 12 days ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.