Opened 9 years ago

Closed 8 years ago

#1378 closed defect (fixed)

First window stays blank when creating a new profile

Reported by: lunar Owned by: mikeperry
Priority: Very High Milestone:
Component: Applications/Torbutton Version: Torbutton: 1.2.5
Severity: Keywords:
Cc: lunar@…, amnesia@… Actual Points:
Parent ID: Points: 6
Reviewer: Sponsor:

Description

When Torbutton is installed as a global extension, the first window displayed for a new profile stays blank.

From what I understood by digging the code, that first window is not tagged with tb_tor_fetched, thus trigerring the defense mechanism in torbutton_check_js_tag().

I do not understand enough of Firefox startup procedure to see how it could be fix. It's not a critical issue, but it's pretty annoying if the homepage is e.g. check.torproject.org.

Child Tickets

Attachments (2)

trace (27.5 KB) - added by lunar 9 years ago.
Torbutton debug output
torbutton_hack_around_bug1378.diff (1.2 KB) - added by lunar 8 years ago.
Crude hack against 1.2.5

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by lunar

Attachment: trace added

Torbutton debug output

comment:1 Changed 9 years ago by mikeperry

Priority: minornormal

comment:2 Changed 9 years ago by mikeperry

Priority: normalmajor

comment:3 Changed 9 years ago by mikeperry

Priority: majorcritical

comment:4 Changed 9 years ago by mikeperry

Points: 6

Reproduce: 1
Fix: 5

comment:5 Changed 9 years ago by mikeperry

Owner: set to mikeperry
Status: newassigned

comment:6 Changed 9 years ago by mikeperry

Is this only when torbutton is installed as a global extension? Or can you also reproduce if Torbutton is installed only to a specific profile?

comment:7 Changed 8 years ago by lunar

Cc: lunar@… added

It is hard to reproduce in a specific profile, as this only affects the very first window displayed for a profile. Subsequent windows (even when closing and opening Firefox again) will not be affected.

Easiest way to see this bug in action is in Tails...

Changed 8 years ago by lunar

Crude hack against 1.2.5

comment:8 Changed 8 years ago by lunar

The previous patch adds a new option "extensions.torbutton.startup_hack" that can be set in initial prefs file (either user.js or prefs.js depending on the setup) to allow homepage to be seen on the first start of the browser.

It has been tested in Tails 0.7. It's pretty crude, hackish, and probably not the right way to go, but I did want to leave a trace of my attempts to solve this...

comment:9 Changed 8 years ago by T(A)ILS developers

Cc: amnesia@… added

comment:10 Changed 8 years ago by arno

I tried to reproduce it but couldn't (what are tails default preferences?)
But I noticed that, if "proxies_applied" preferences is true (at startup) torbutton_update_status returns before calling torbutton_toggle_jsplugins.
Does the bug happen if you start tails with extensions.torbutton.proxies_applied set to true by default ?

comment:11 Changed 8 years ago by lunar

Resolution: fixed
Status: assignedclosed

The bug has actually been fixed with commit a61cd27, thanks arno.

Note: See TracTickets for help on using tickets.