Opened 5 years ago

Closed 5 years ago

#13797 closed defect (wontfix)

building tor-browser.git on Mac (non-cross-compiled) is broken

Reported by: arthuredelstein Owned by: tom
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords:
Cc: tom@…, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I often build tor-browser.git on Mac non-cross compiled, for convenient debugging. The following two recent patches cause the build to fail:

https://gitweb.torproject.org/tor-browser.git/commit/b8b6d86a5b6407b9e0f42bfe1de188e5be49b47d
https://gitweb.torproject.org/tor-browser.git/commit/892f8b664e82abe2afb9b488f5e095c7d4006629

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by tom

Owner: changed from tbb-team to tom
Status: newassigned

comment:2 Changed 5 years ago by tom

I'm trying to replicate on my Mac (running 10.10) and the first error I'm getting is about not having clang in ~/build/x-tools/...etc. Could you let me know how you're configuring the build tools?

comment:3 Changed 5 years ago by arthuredelstein

My build stops with the following messages:

 2:27.63 Traceback (most recent call last):
 2:27.63   File "/projects/torproject/tor-browser31/toolkit/library/dependentlibs.py", line 139, in <module>
 2:27.63     main()
 2:27.63   File "/projects/torproject/tor-browser31/toolkit/library/dependentlibs.py", line 136, in main
 2:27.63     print '\n'.join(dependentlibs(lib, options.libpaths, func) + [lib])
 2:27.63   File "/projects/torproject/tor-browser31/toolkit/library/dependentlibs.py", line 99, in dependentlibs
 2:27.63     for dep in func(lib):
 2:27.63   File "/projects/torproject/tor-browser31/toolkit/library/dependentlibs.py", line 74, in dependentlibs_otool
 2:27.63     proc = subprocess.Popen(["../../../../../x-tools/x86_64-apple-darwin10/bin/" + TOOLCHAIN_PREFIX + 'otool', '-l', lib], stdout = subprocess.PIPE)
 2:27.63   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 711, in __init__
 2:27.63     errread, errwrite)
 2:27.63   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1308, in _execute_child
 2:27.64     raise child_exception
 2:27.64 OSError: [Errno 2] No such file or directory
 2:27.64 make[5]: *** [../../../dist/bin/dependentlibs.list] Error 1
 2:27.64 make[5]: *** Deleting file `../../../dist/bin/dependentlibs.list'
 2:27.64 make[4]: *** [toolkit/library/build/libs] Error 2
 2:27.64 make[3]: *** [libs] Error 2
 2:27.64 make[2]: *** [default] Error 2
 2:27.64 make[1]: *** [realbuild] Error 2
 2:27.64 make: *** [build] Error 2
 2:27.68 99 compiler warnings present.

Unfortunately I'm not sure how I installed clang, but it appears to be located at /opt/local/libexec/llvm-3.3/bin

comment:4 Changed 5 years ago by arthuredelstein

Your change seems to add a fairly hard-coded location for otool. I wonder if we could get around this problem by just adding "../../../../x-tools/x86_64-apple-darwin10/bin/" + TOOLCHAIN_PREFIX to the system PATH. I'm not sure if this should happen inside the python script, or somewhere upstream.

comment:5 Changed 5 years ago by gk

Cc: gk added

comment:6 Changed 5 years ago by gk

It is probably the simplest to just patch the offending part out before you start building. A proper fix should land in https://bugzilla.mozilla.org/show_bug.cgi?id=1067893.

comment:7 Changed 5 years ago by arthuredelstein

OK, sounds good.

comment:8 Changed 5 years ago by tom

I took Georg's patch and applied it to a 4.5 alpha and it built. So this might fix things for you.

The commit is: https://github.com/tomrittervg/tor-browser/commit/261d081aaf954fae39c8d9081ea0501670b56021

comment:9 Changed 5 years ago by gk

Resolution: wontfix
Status: assignedclosed

Given the available workarounds for a dev I mark this as "wontfix".

Note: See TracTickets for help on using tickets.