Opened 5 years ago

Closed 5 years ago

#13811 closed defect (fixed)

Tor accidentally forces non decorated address when trying to avoid them on ipv6 automaps

Reported by: klondike Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.10
Severity: Keywords: tor-client 025-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor added support for IPv6 automaps recently, sadly these are broken as the address returned is not decorated because of a programming error.

The attached patch solves this issue and the strange behaviour after getting the right address with the patch on #13808

Child Tickets

Attachments (1)

lol3.patch (1.1 KB) - added by klondike 5 years ago.
Patch fixing IPv6 automaps

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by klondike

Attachment: lol3.patch added

Patch fixing IPv6 automaps

comment:1 Changed 5 years ago by klondike

Status: newneeds_revision

comment:2 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-final

Did you mean to mark this patch "needs_revision" ? We use that status to indicate that a patch isn't done yet, and needs to be changed. Did you mean "needs_review" ?

comment:3 Changed 5 years ago by nickm

Status: needs_revisionneeds_review

comment:4 Changed 5 years ago by klondike

Yes nick I meant needs_review, sorry for that it's the first time I contribute patches to tor :)

comment:5 Changed 5 years ago by klondike

You may also want to consider backporting this fix to 0.2.5 BTW

comment:6 Changed 5 years ago by klondike

Keywords: tor-client 025-backport added
Version: Tor: 0.2.6.1-alphaTor: 0.2.5.10

comment:7 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.5.x-final

lgtm; merging and marking for possible backport. Probably some of our other bugs are fixed now; we should check the other automap stuff.

comment:8 Changed 5 years ago by klondike

nickm I have been running this and the patches on 13808 on our transparent Tor proxy at GHS for already 1 month and it works like a charm :)

The proxy provides both IPv4 and IPv6 private addresses for access to .onion addresses and then interecepts the traffic with a REDIRECT rule.

We are running Gentoo's net-misc/tor-0.2.5.10-r1 (updating to r3 as we speak).

comment:9 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final
Resolution: fixed
Status: needs_reviewclosed

Not backporting these.

Note: See TracTickets for help on using tickets.