Tor accidentally forces non decorated address when trying to avoid them on ipv6 automaps

Tor added support for IPv6 automaps recently, sadly these are broken as the address returned is not decorated because of a programming error.

The attached patch solves this issue and the strange behaviour after getting the right address with the patch on #13808 (moved)

Trac:
Username: klondike

changed milestone to %Tor: 0.2.6.x-final

added 025-backport component::core tor/tor milestone::Tor: 0.2.6.x-final priority::medium reporter::klondike resolution::fixed status::closed tor-client type::defect version::tor 0.2.5.10 labels

Trac:
Username: klondike

lol3.patch

Patch fixing IPv6 automaps

Trac:
Username: klondike

Trac:
Username: klondike
Status: new to needs_revision

Did you mean to mark this patch "needs_revision" ? We use that status to indicate that a patch isn't done yet, and needs to be changed. Did you mean "needs_review" ?

Trac:
Milestone: N/A to Tor: 0.2.6.x-final

Trac:
Status: needs_revision to needs_review

Yes nick I meant needs_review, sorry for that it's the first time I contribute patches to tor :)

Trac:
Username: klondike

You may also want to consider backporting this fix to 0.2.5 BTW

Trac:
Username: klondike

Trac:
Username: klondike
Version: Tor: 0.2.6.1-alpha to Tor: 0.2.5.10
Keywords: N/A deleted, tor-client 025-backport added

lgtm; merging and marking for possible backport. Probably some of our other bugs are fixed now; we should check the other automap stuff.

Trac:
Milestone: Tor: 0.2.6.x-final to Tor: 0.2.5.x-final

nickm I have been running this and the patches on 13808 on our transparent Tor proxy at GHS for already 1 month and it works like a charm :)

The proxy provides both IPv4 and IPv6 private addresses for access to .onion addresses and then interecepts the traffic with a REDIRECT rule.

We are running Gentoo's net-misc/tor-0.2.5.10-r1 (updating to r3 as we speak).

Trac:
Username: klondike

Not backporting these.

Trac:
Milestone: Tor: 0.2.5.x-final to Tor: 0.2.6.x-final
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#13811 (closed)