Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#13813 closed enhancement (wontfix)

Add router_have_consensus_path() as status/consensus-exit GETINFO control event

Reported by: teor Owned by:
Priority: Very Low Milestone:
Component: Core Tor/Tor Version: Tor: 0.2.6.1-alpha
Severity: Keywords: easy lorax tor-relay tor-spec control-spec
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by teor)

Split from #13718:

We could add router_have_consensus_path() as a GETINFO control event called status/consensus-exit or something.
But this is low priority, as knowing that the consensus is missing exits only impacts on test networks.

These details have been obsoleted by changes in #13718:
> We may also need to update the status/enough-dir-info GETINFO control event - should we add status/enough-dir-info/exit and status/enough-dir-info/internal (we default status/enough-dir-info to exit for backwards compatibility).

nickm:
Sounds fine, though it could be a separate ticket.

Note: the relevant code is located in src/or/control.c in getinfo_helper_events() around line 2019.

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by teor

Version: Tor: unspecifiedTor: 0.2.6.1-alpha

comment:2 Changed 5 years ago by teor

Keywords: tor-spec control-spec added

This will also require a change around line 717 of the Tor control-spec.txt

comment:3 Changed 5 years ago by teor

We could also add router_have_consensus_exit() (does the current consensus have an exit?), although this can be derived from the consensus itself.

comment:4 Changed 5 years ago by teor

These new events should be derived from the values of:

  • router_have_minimum_dir_info(DIR_INFO_CIRCUIT_INTERNAL) (obsoleted #13718)
  • router_have_minimum_dir_info(DIR_INFO_CIRCUIT_EXIT) (obsoleted #13718)
  • router_have_consensus_exit()
    • we don't have a name for this one yet, how about "status/consensus-exit"?

Also note arma's comments in #13718 comment 17:

So there's still value imo in waiting for circuit-building until we have all the network info that we need for a variety of actions. The bug here is that we have the wrong definition of "all the network info that we need" when the network has no exits. So we should be fixing that definition.

This will be implemented as part of #13718, but it's still worth being aware of.

Last edited 5 years ago by teor (previous) (diff)

comment:5 Changed 5 years ago by teor

Description: modified (diff)
Priority: minortrivial
Summary: Add exit and internal sub-events to status/enough-dir-info GETINFO control eventAdd router_have_consensus_path() as status/consensus-exit GETINFO control event

comment:6 Changed 5 years ago by teor

Parent ID: #13718
Resolution: wontfix
Status: newclosed

Not required to resolve #13718, and as it only impacts a particular configuration of test/private networks during bootstrapping, I can't really see a need for this feature.

comment:7 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:8 Changed 3 years ago by nickm

Milestone: Tor: 0.3.???

Milestone deleted

Note: See TracTickets for help on using tickets.