Opened 4 years ago

Last modified 22 months ago

#13828 new enhancement

Refactor rend_cache_store_v2_desc_as_dir and rend_cache_store_v2_desc_as_client to avoid duplicate code

Reported by: arma Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, easy, refactor, technical-debt
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

There's a lot of overlapping code here in terms of checking the timestamp on the parsed descriptor, checking if we have a newer one already, creating and linking the new entry, etc. It's not exactly the same but a lot of it sure is similar. This is the sort of situation where a subfunction to do the shared behavior might be handy.

Child Tickets

Change History (16)

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

We should have a look at this when we next touch the code, but it isn't should-do-for-its-own-sake in 0.2.6 IMO.

comment:2 Changed 4 years ago by dgoulet

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

comment:3 Changed 4 years ago by nickm

Status: newassigned

comment:4 Changed 4 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:6 Changed 3 years ago by nickm

Keywords: SponsorR removed
Sponsor: SponsorR

Bulk-replace SponsorR keyword with SponsorR sponsor field in Tor component.

comment:7 Changed 3 years ago by dgoulet

Keywords: 027-triaged-1-out removed

comment:8 Changed 3 years ago by nickm

Points: small
Severity: Normal

comment:9 Changed 3 years ago by dgoulet

Priority: MediumVery Low

comment:10 Changed 3 years ago by dgoulet

Sponsor: SponsorRSponsorR-can

Move those from SponsorR to SponsorR-can.

comment:11 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:12 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:13 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:14 Changed 22 months ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:15 Changed 22 months ago by dgoulet

Keywords: refactor added
Points: small1
Sponsor: SponsorR-can

comment:16 Changed 22 months ago by nickm

Keywords: technical-debt added
Note: See TracTickets for help on using tickets.