Opened 5 years ago

Closed 5 years ago

Last modified 15 months ago

#13852 closed defect (fixed)

Check HTTP requests from add-ons

Reported by: sukhbir Owned by:
Priority: Medium Milestone:
Component: Archived/Tor Messenger Version:
Severity: Keywords:
Cc: arlolra Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We are preventing add-ons from auto-updating but the console logs this:

1417114612642	addons.update-checker	WARN	HTTP Request failed for an unknown reason
1417114615860	addons.update-checker	WARN	Update manifest for {972ce4c6-7e08-4474-a285-3208198ce6fd} did not contain an updates property
1417114616416	addons.update-checker	WARN	Update manifest for ctypes-otr@tormessenger did not contain an updates property

So while the request fails, it still makes the request. We should check this.

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by sukhbir

So I just checked that no actual request is being made. But since we have disabled add-ons, we should not get this message.

comment:2 Changed 5 years ago by sukhbir

Update: We have fixed this for ctypes-otr by adding updateURL and setting it to 127.0.0.1. For the other extension, {972ce4c6-7e08-4474-a285-3208198ce6fd}, it is the default theme and we can add something similar to it, but in any case, there is no actual request being made.

comment:3 Changed 5 years ago by sukhbir

Resolution: fixed
Status: newclosed

We have also added https://127.0.0.1/ as the update URL for the default theme.

There is no actual request being made.

comment:4 Changed 15 months ago by traumschule

<+sukhe> hello. yes, I think it's fine to close the tickets. thanks for doing what we should done earlier :)

sad but true:
https://blog.torproject.org/sunsetting-tor-messenger

luckily there are alternatives:
https://blog.torproject.org/tor-heart-onion-messaging

.. and maybe someday

Note: See TracTickets for help on using tickets.