Opened 5 years ago

Closed 5 years ago

#13891 closed defect (fixed)

Circuit display causes "TypeError: circuitStatuses is undefined"

Reported by: gk Owned by: arthuredelstein
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-torbutton, tbb-circuit-display, TorBrowserTeam201503R, GeorgKoppen201503R
Cc: mikeperry, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I had used an FTE bridge which after a while gave me:

*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: circuitStatuses is undefined
Full stack: getCircuitStatusByID@chrome://torbutton/content/tor-circuit-display.js:122:12
TaskImpl_run@resource://gre/modules/Task.jsm:282:13

*************************

The patch for #13671 which made it into 4.5-alpha-2 was applied.

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by gk

Cc: mikeperry mcs added
Keywords: TorBrowserTeam2012 added

Marked #13939 as duplicate.

comment:2 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201502 added; TorBrowserTeam2012 removed

Arthur: I am also noticing on occasion that the circuit status menu disappears from some sites on TBB 4.5a3. I am not sure if it is related to this exception, but I usually see it in my terminal window when this bug happens.

comment:3 Changed 5 years ago by arthuredelstein

Keywords: tbb-circuit-display added

comment:4 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201503 added; TorBrowserTeam201502 removed

comment:5 Changed 5 years ago by arthuredelstein

Here's a patch that fixes this error, and also avoids a similar error elsewhere in the code.

https://github.com/arthuredelstein/torbutton/commit/6d04457c2a2e60e5970fd5d5e98d79f9fad8e726

comment:6 Changed 5 years ago by arthuredelstein

Status: newneeds_review

comment:7 Changed 5 years ago by arthuredelstein

Keywords: TorBrowserTeam201503R added; TorBrowserTeam201503 removed

comment:8 Changed 5 years ago by gk

Keywords: GeorgKoppen201503R added

comment:9 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Merged as commit bf2ee7eddab0eaed16ea6825ab084a6a183054f6 (again with small commit message adjustments).

Note: See TracTickets for help on using tickets.