Opened 5 years ago

Closed 5 years ago

#13902 closed defect (wontfix)

Tor windows installer command line broken

Reported by: r04r Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version: Tor: unspecified
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The tor windows installer that can be found at https://dist.torproject.org/win32/ has a bug with regard to the command line handling, according to the help & the source it should handle the command line arguments -x and -b (https://gitweb.torproject.org/tor.git/tree/contrib/win32build/tor-mingw.nsi.in#n258), -x to extract all content and -b to extract just the binaries. The binaries are never extracted, thus the -b switch does nothing and the -x switch is incomplete, extracting only the documentation.

I believe this to be because the ExtractBinaries function lacks an SetOutPath call which the ExtractDocuments function does have.

This is my first ticket on trac so I hope I did this right.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by r04r

How to reproduce/verify the issue exists (on windows):

  • Download https://dist.torproject.org/win32/tor-0.2.4.22-win32.exe to an empty directory
  • Run tor-0.2.4.22-win32.exe -? to confirm advertised command line options
  • Run tor-0.2.4.22-win32.exe -b to observe nothing happens
  • Run tor-0.2.4.22-win32.exe -x to observe only the documentation being extracted to the current directory
Last edited 5 years ago by r04r (previous) (diff)

comment:2 Changed 5 years ago by gk

Resolution: wontfix
Status: newclosed

The expert bundle is not built anymore this way. Rather, it is now a zip file that gets build during the Tor Browser build: https://dist.torproject.org/torbrowser/4.0.2/tor-win32-tor-0.2.5.10.zip (and https://dist.torproject.org/torbrowser/4.0.2/tor-win32-tor-0.2.5.10.zip.asc) is an example. There are currently no plans on our side to switch to an installer back. Thus, marking this as wontfix.

comment:3 Changed 5 years ago by r04r

http://torproject.org still links to the installer under the expert bundle, with no links to the .zip (So I'm also not sure where to find documentation about the new bundle, resulting in my following complains). Additionally the provided .zip file appears to be a dynamically linked tor instead of a statically linked one. It also does not output anything to stdout and detaches from the console immediately.

Maybe I'm using it wrong, but the new zip appears to be completely unusable. Running tor.exe does not output anything to the console, does not respond to command line options and only results in a tor.exe running in the background doing who knows what.

Last edited 5 years ago by r04r (previous) (diff)

comment:4 Changed 5 years ago by r04r

Resolution: wontfix
Status: closedreopened

comment:5 Changed 5 years ago by cypherpunks

Resolution: wontfix
Status: reopenedclosed

torproject.org still links to the installer under the expert bundle, with no links to the .zip

Now torproject.org links to the .zip

Maybe I'm using it wrong, but the new zip appears to be completely unusable. Running tor.exe does not output anything to the console, does not respond to command line options and only results in a tor.exe running in the background doing who knows what.

It's #13819

Note: See TracTickets for help on using tickets.