Remove "bridge pool assignment" UI element from Atlas/Globe

For further info: https://lists.torproject.org/pipermail/tor-dev/2014-October/007617.html

We should now remove the UI elements so that users don't get confused.

added component::metrics/globe globe-0.4.9 owner::isis priority::low resolution::fixed status::closed type::defect ui labels

Yes, the pool_assignment field is gone. Sorry if this caused any trouble. It's an optional field, so I figured it's not required to send a warning.

Do you want to replace this field with the new transports field? It's a list of strings, not a single string. But the content should be similarly interesting to users.

Replying to karsten:

Do you want to replace this field with the new transports field? It's a list of strings, not a single string. But the content should be similarly interesting to users.

Good idea. Here's the (trivial) patch: https://gitweb.torproject.org/user/phw/atlas.git/commit/?h=bug_13921

Looks good!

Thanks, merged and deployed. I'm leaving the ticket open for now in case isis wants to do the same for Globe.

Trac:
Owner: phw to isis
Status: new to assigned

Trac:
Component: Atlas to Globe

Someone sent me a patch that I need to review for this.

Trac:
Status: assigned to needs_review

Okay, the patch is the first commit in my trac-13921 branch. I fixed one of the onionoodetail.test.js unittests in another commit on top of it.

Before you merge to master, please note my last comment on #13782 (moved): "Note: As discussed with Isis on IRC, I deployed master plus this patch last week. We should merge it soon, or we'll later deploy a branch that doesn't have this patch."

Of course, feel free to merge the #13782 (moved) commit on top of this one. We should just make sure that we don't deploy something without that commit.

Thanks!

#13782 (moved) is merged, and so is my trac-13921 branch, for Globe-0.4.9.

Thanks to Karsten for redeploying!

Trac:
Keywords: N/A deleted, globe-0.4.9, ui added
Resolution: N/A to fixed
Status: needs_review to closed

closed