Opened 5 years ago

Closed 5 years ago

#13921 closed defect (fixed)

Remove "bridge pool assignment" UI element from Atlas/Globe

Reported by: phw Owned by: isis
Priority: Low Milestone:
Component: Metrics/Globe Version:
Severity: Keywords: globe-0.4.9, ui
Cc: isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For further info: https://lists.torproject.org/pipermail/tor-dev/2014-October/007617.html

We should now remove the UI elements so that users don't get confused.

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by karsten

Yes, the pool_assignment field is gone. Sorry if this caused any trouble. It's an optional field, so I figured it's not required to send a warning.

Do you want to replace this field with the new transports field? It's a list of strings, not a single string. But the content should be similarly interesting to users.

comment:2 in reply to:  1 Changed 5 years ago by phw

Replying to karsten:

Do you want to replace this field with the new transports field? It's a list of strings, not a single string. But the content should be similarly interesting to users.

Good idea. Here's the (trivial) patch: https://gitweb.torproject.org/user/phw/atlas.git/commit/?h=bug_13921

comment:3 Changed 5 years ago by karsten

Looks good!

comment:4 Changed 5 years ago by phw

Owner: changed from phw to isis
Status: newassigned

Thanks, merged and deployed. I'm leaving the ticket open for now in case isis wants to do the same for Globe.

comment:5 Changed 5 years ago by karsten

Component: AtlasGlobe

comment:6 Changed 5 years ago by isis

Status: assignedneeds_review

Someone sent me a patch that I need to review for this.

comment:7 Changed 5 years ago by isis

Okay, the patch is the first commit in my trac-13921 branch. I fixed one of the onionoodetail.test.js unittests in another commit on top of it.

comment:8 Changed 5 years ago by karsten

Before you merge to master, please note my last comment on #13782: "Note: As discussed with Isis on IRC, I deployed master plus this patch last week. We should merge it soon, or we'll later deploy a branch that doesn't have this patch."

Of course, feel free to merge the #13782 commit on top of this one. We should just make sure that we don't deploy something without that commit.

Thanks!

comment:9 Changed 5 years ago by isis

Keywords: globe-0.4.9 ui added
Resolution: fixed
Status: needs_reviewclosed

#13782 is merged, and so is my trac-13921 branch, for Globe-0.4.9.

Thanks to Karsten for redeploying!

Note: See TracTickets for help on using tickets.