Opened 5 years ago

Closed 4 years ago

#13936 closed defect (fixed)

circuit_has_opened() should be called for rendezvous circuit

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-hs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In circuit_get_open_circ_or_launch(), for a rendezvous circuit, we directly called rend_client_rendcirc_has_opened() but I think circuit_has_opened() should be prefered here which then use a specialized function for each circuit purpose. Also, it fires a controller event where the former did not.

Side effect is that connection_ap_attach_pending() is called right after but I don't think it affects anything here but that needs review of course.

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by dgoulet

Status: newneeds_review

Trivial patch can be found in my branch bug13936_025_v1.

I based it on 0.2.5 since I need this to trigger a tracing event for that version which I can then use on master for performance comparaison.

comment:2 Changed 5 years ago by nickm

looks good to me; needs a changes file.

comment:3 Changed 5 years ago by dgoulet

Here you go, everything in bug13936_025_v2.

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-final

merged; thanks! Marking for possible backport, though I think we can probably leave 0.2.5 how it is...

comment:5 Changed 5 years ago by dgoulet

Possibly... but my hs tracing branch based on 0.2.5 needs that else I don't get the "circuit opened" event for a rendezvous circuit :(

comment:6 Changed 4 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final
Resolution: fixed
Status: needs_reviewclosed

Not backporting these.

Note: See TracTickets for help on using tickets.