Opened 5 years ago

Closed 5 years ago

#13941 closed defect (fixed)

log_new_relay_greeting() called for hidden-service keygen

Reported by: meejah Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.6.1-alpha
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

init_key_from_file() in router.c calls log_new_relay_greeting() which congratulates you for running a relay -- however, init_key_from_file() is also called from rendservice.c rend_service_load_keys() which leads to a misleading log-message if you add a new hidden-service.

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by meejah

I just added another option to init_key_from_file -- not sure if this is the best approach.

https://github.com/meejah/tor/tree/ticket-13941

comment:2 Changed 5 years ago by meejah

Status: newneeds_review

comment:3 Changed 5 years ago by arma

Version: Tor: 0.2.5.10Tor: 0.2.6.1-alpha

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-final

Looks good; just needs a changes/ file. Can you write one, or should I?

comment:5 Changed 5 years ago by meejah

I will write one as an exercise to myself since I haven't done that for Tor before :)

Per HACKING, you want a new branch with precisely one changeset that includes the code + changes/ file, right?

comment:7 Changed 5 years ago by nickm

For future reference: It's okay to send the branch in either way. The changes file looks good; the only thing to remember for next time its that we try to say what the bug number is, and when it first appeared.

(Thanks, merging!)

comment:8 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.