Opened 5 years ago

Closed 5 years ago

#14001 closed defect (fixed)

Fix clang warning, incorrect comment about IPv6, and apparent typo in log buffer size

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.6.1-alpha
Severity: Keywords: clang
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

clang gives a warning about the address of an array mid-way through a structure always being non-NULL. AFAICT, this is true, so I've disabled the check.

A comment about an IPv6 address string incorrectly refers to an IPv4 address format.

A log buffer is sized 10024 rather than 10240.

I'll post a branch soon with fixes to these.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by teor

Owner: set to teor
Status: newassigned

Branch: bug14001-clang-warning
Repository: ​​​​​​​https://github.com/teor2345/tor.git

comment:2 Changed 5 years ago by teor

Status: assignedneeds_review

comment:3 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

This patch had unrelated changes in address.c and log.c. I split it up into three patches, then merged them. Thanks!

(I also removed the comment about why we don't do that check any more. I prefer not to retain dead code in comments unless there's a good chance it will need to go back in.)

Note: See TracTickets for help on using tickets.