Opened 5 years ago

Closed 4 years ago

#14019 closed defect (worksforme)

Fix Python 2 issues in chutney refactor

Reported by: teor Owned by: nickm
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords:
Cc: nickm, mvdan, dgoulet Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Please merge fix-python2-issues from https://github.com/teor2345/chutney.git

This fixes:

  • Brackets around print statements
  • Double-opening a file

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by mvdan

Looks like nickm didn't see my ping on irc about me forgetting a few python2 and pep8 aspects since the upstream changes. For example, the prints you are fixing are fixed in my rebased commit http://git.mvdan.cc/mvdan/chutney/commit/?id=13058215b87c664e41753c89b39a8f19800937a9

And you are right with the change in runConfigFile. Another way to fix it would be to pass the path to the function, but essentially it's the same thing.

comment:2 Changed 5 years ago by nickm

So, mvdan, should I merge this, or something else?

comment:3 Changed 4 years ago by cypherpunks

Severity: Normal

With the current master (42e7bd4c53e3a84ddae3d5900017753b32e998df) the brackets around print statements is no longer an issue.

However, the change in runConfigFile in teor's branch is required to make that part work under Python 3. The change in runConfigFile should be brought over to #16904.

IMO this ticket can be closed because the summary states this ticket fixes Python 2 issues and Chutney works under Python 2 now.

Objections?

comment:4 Changed 4 years ago by teor

Resolution: worksforme
Status: newclosed
Note: See TracTickets for help on using tickets.