Opened 5 years ago

Closed 5 years ago

#14122 closed defect (fixed)

add environment variable to hide TBB's logo

Reported by: proper Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201501, GeorgKoppen201501, tbb-4.5-alpha-3
Cc: proper, linostar, T(A)ILS, developers, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Speaking as a user of Tails and a maintainer of Whonix, I want to point out, that showing the ​Tor Browser Bundle Logo when using tor-launcher only for configuring Tor without TBB is inappropriate and confusing. It should not be shown in that mode.

Could you please add an environment variable such as TOR_HIDE_LOGO?

That would also be useful to avoid trademark issues when redistributing original, unmodified TBB in (linux) distributions.

Related:

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by mcs

Cc: mcs brade added

I am not an attorney, but wouldn't you need to remove the offending image files from TBB (Tor Launcher) anyway? If so, then the build time option that we already implemented for #12451 is sufficient.

Also, it is not clear to me that you are required to or even if you should remove the Tor logo from TBB if you are redistributing it without modification. But, as I said, I cannot provide legal advice.

comment:2 Changed 5 years ago by proper

The main argument here is the usability one. The logo says "Tor Browser Bundle". But that's wrong and confusing when using tor-launcher in standalone mode.


About the legal question... Good point...
The background of my cautiousness: here.

I think as Andrew / TPO says We don't want to be trademark bullies, but we will use trademark to protect the public's ability to recognize Tor Project software., it's really not about trademark bulling. The main practical reason is to shield the TPO support team from inquiries that are outside of their scope. I.e. reporting tor-launcher problems when it were running in Whonix-Gateway in standalone mode would be unsupported by TPO. Also to protect TPO's reputation so users do not interrelate potentially huge issues causes by third parties with TPO.

It's not on a "you must not ship that file" level, fortunately.

Also by providing a TOR_HIDE_LOGO environment variable, one could argue that it's an implicit permission to keep the file as long as users are clear. I mean, it would be in the spirit of the trademark page.


Got any hints how this could be best implemented? Linostar might provide a patch.

comment:3 Changed 5 years ago by proper

Status: newneeds_review

linostar wrote a patch.

Checking env.exists + env.get (linostar):

Checking env.exists only (modified by me):

Both tested by me. Working fine.

Please review.

comment:4 Changed 5 years ago by gk

Keywords: TorBrowserTeam201501R added

comment:5 Changed 5 years ago by gk

Keywords: tbb-4.5-alpha-3 added

comment:6 Changed 5 years ago by mcs

Keywords: PearlCrescent201501R added

comment:7 Changed 5 years ago by mcs

Keywords: GeorgKoppen201501R added; PearlCrescent201501R removed

Kathy and I made a revised patch that is a little simpler (relying upon CSS more).
We also changed the env var name to TOR_HIDE_BROWSER_LOGO.

proper and gk -- can you please do a quick review?

https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug14122&id=7dc7fcda6b4ea5f9cb7a43a113856a3fdbd49fb4

comment:8 Changed 5 years ago by gk

Keywords: TorBrowserTeam201501 GeorgKoppen201501 added; TorBrowserTeam201501R GeorgKoppen201501R removed
Resolution: fixed
Status: needs_reviewclosed

Looks good and works as expected. This is commit c1ee486489e33bb07164448b096afba5d899f661. I just removed an superfluous whitespace in your commit message and made a child commit removing a trailing whitespace in your code.

Note: See TracTickets for help on using tickets.