Opened 4 years ago

Closed 23 months ago

#14124 closed defect (worksforme)

No, don't mark my guard as unreachable. Nothing is reachable.

Reported by: cypherpunks Owned by: cypherpunks
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords: SponsorU-deferred
Cc: isis Actual Points:
Parent ID: Points: unclear
Reviewer: Sponsor:

Description

Tor should provide a means for the user to express their preference for Tor to not be so hasty to give up and choose a new guard, even if that means no connection to the Tor network at all. The AssumeReachable option could be repurposed for this.

  • src/or/entrynodes.c

    a b entry_guard_register_connect_status(const char *digest, int succeeded, 
    794794      smartlist_del_keeporder(entry_guards, idx);
    795795      log_entry_guards(LOG_INFO);
    796796      changed = 1;
    797     } else if (!entry->unreachable_since) {
     797    } else if (!entry->unreachable_since && !get_options()->AssumeReachable) {
    798798      log_info(LD_CIRC, "Unable to connect to entry guard '%s' (%s). "
    799799               "Marking as unreachable.", entry->nickname, buf);
    800800      entry->unreachable_since = entry->last_attempted = now;

Child Tickets

Change History (23)

comment:1 Changed 4 years ago by cypherpunks

Status: newneeds_review

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-final

See also proposal 241.

comment:3 Changed 4 years ago by nickm

Keywords: 027-triaged-1-in added

Marking more tickets as triaged-in for 0.2.7

comment:4 Changed 4 years ago by isabela

Keywords: SponsorU added
Points: unclear
Priority: normalmajor
Version: Tor: 0.2.7

comment:5 Changed 4 years ago by nickm

Owner: set to nickm
Status: needs_reviewaccepted

This is a good idea, but the patch is wrong. AssumeReachable doesn't mean this at all; see the documentation for AssumeReachable.

comment:6 in reply to:  5 Changed 4 years ago by cypherpunks

Replying to nickm:

AssumeReachable doesn't mean this at all; see the documentation for AssumeReachable.

I am aware; that's what I meant by 'repurposed' - the documentation would also change.

comment:7 Changed 4 years ago by teor

AssumeReachable already has a purpose, and it's used by chutney, various test networks, and plenty of users.

Please, let's create an entirely new option, say RotateUnreachableGuard or something.

comment:8 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:9 Changed 4 years ago by nickm

Keywords: SponsorU removed
Sponsor: SponsorU

Bulk-replace SponsorU keyword with SponsorU field.

comment:10 Changed 4 years ago by isis

Cc: isis added
Severity: Normal

comment:11 Changed 3 years ago by teor

Status: acceptedneeds_revision

comment:12 Changed 3 years ago by nickm

Owner: changed from nickm to cypherpunks
Status: needs_revisionassigned

setting cypherpunks as the owner of this needs_revision ticket. (!!!)

comment:13 Changed 3 years ago by nickm

Status: assignedneeds_revision

comment:14 Changed 3 years ago by nickm

Sponsor: SponsorUSponsorU-can

comment:15 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

comment:16 Changed 3 years ago by nickm

Keywords: SponsorU-deferred added
Sponsor: SponsorU-can

Remove the SponsorU status from these items, which we already decided to defer from 0.2.9. add the SponsorU-deferred tag instead in case we ever want to remember which ones these were.

comment:17 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:18 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:19 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:20 Changed 2 years ago by nickm

Keywords: 027-triaged-in added

comment:21 Changed 2 years ago by nickm

Keywords: 027-triaged-in removed

comment:22 Changed 2 years ago by nickm

Keywords: 027-triaged-1-in removed

comment:23 Changed 23 months ago by nickm

Resolution: worksforme
Status: needs_revisionclosed

This should now be obsoleted by prop271, which stays with preferred guards much more aggressively.

Note: See TracTickets for help on using tickets.