Opened 3 years ago

Closed 3 years ago

#14141 closed defect (fixed)

enhancments and fixes for systemd support

Reported by: tomek@… Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.6.2-alpha
Severity: Keywords: systemd watchdog patch
Cc: tomek@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The following patch series contains:

1) fix unit & code to work with both RunAsDaemon = 0 or 1

2) improve information about state presented to administrator

3) fix and enable watchdog support

Detailed descriptions inside each patch.

Child Tickets

Attachments (3)

Change History (7)

Changed 3 years ago by tomek@…

comment:1 Changed 3 years ago by misc

The 3 patch look sane, and I would urge at least the 3rd one to be merged.

If we could get more information on the coverty issue, it would be nice, but not blocking a merge or anything.

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.2.6.x-final
Status: newneeds_review

The coverity comment is cut-and-pasted from main.c .

How tested are these? They look plausible at a first glance.

tomek, if you know systemd stuff, could you also have a look at #13805 ? It needs more reviewers.

comment:3 Changed 3 years ago by tomek@…

I've run patched daemon for 3 hours acting as relay. I've tested with both RunAsDaemon 0 and 1. I've also tested with two watchdog intervals: 5 seconds an 1 minute.
Development was done on Fedora 21 with systemd 216.

comment:4 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Sounds good to me, and still looks good a day later. Merged to master. Thanks!

Note: See TracTickets for help on using tickets.