Opened 5 years ago

Closed 5 years ago

#14158 closed defect (fixed)

HTTPS Everywhere Atlas ruleset pages have broken links to ruleset histories at gitweb.torproject.org

Reported by: cypherpunks Owned by:
Priority: Medium Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For each ruleset page in the HTTPS Everywhere Atlas, it appears that the links to the EFF's git repository at the gitweb.torproject.org domain are broken. For example, the atlas page at https://www.eff.org/https-everywhere/atlas/domains/eff.org.html includes the following links which produce an "Invalid request" error.

https://gitweb.torproject.org/https-everywhere.git/history/3.0:/src/chrome/content/rules/EFF.xml

https://gitweb.torproject.org/https-everywhere.git/history/master:/src/chrome/content/rules/EFF.xml

Given a rulset with the name XXXXXXXX.xml, it appears that the following URLs should be used for linking to the ruleset history.

Linking to a ruleset's history in the stable branch:
https://gitweb.torproject.org/https-everywhere.git/log/src/chrome/content/rules/XXXXXXXX.xml?h=3.0

Linking to a ruleset's history in the development branch:
https://gitweb.torproject.org/https-everywhere.git/log/src/chrome/content/rules/XXXXXXXX.xml?h=master

In addition, it appears that the links to the stable tree and development tree under the "Information current as of:" text should be as follows:

Stable tree:
https://gitweb.torproject.org/https-everywhere.git/log/src/chrome/content/rules/?h=3.0
Development tree:
https://gitweb.torproject.org/https-everywhere.git/log/src/chrome/content/rules/?h=master

Child Tickets

Change History (1)

comment:1 Changed 5 years ago by jsha

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.