Opened 6 years ago

Closed 6 years ago

#14166 closed defect (fixed)

torsock's configure.ac: avoid tests which have both -pie and -static

Reported by: blueness Owned by: dgoulet
Priority: Medium Milestone:
Component: Core Tor/Torsocks Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Building and linking with both -pie and -static is not supported for some toolchain combinations (eg. glibc or binutil's gold). Yet this combination is hit if the check for gcc hardening is done before AC_PROG_LIBTOOL and AC_ENABLE_STATIC. We avoid the issue by moving the gcc hardening check to after AC_PROG_LIBTOOL and friends.

See:

https://sourceware.org/bugzilla/show_bug.cgi?id=17826
https://sourceware.org/bugzilla/show_bug.cgi?id=16428
https://bugs.gentoo.org/show_bug.cgi?id=533862

Child Tickets

Attachments (1)

0001-configure.ac-avoid-tests-which-have-both-pie-and-sta.patch (3.3 KB) - added by blueness 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by blueness

Oh please note that -D_FORTIFY_SOURCES=2 should go into CPPFLAGS. That change was also included.

comment:2 Changed 6 years ago by blueness

Component: - Select a componentTorsocks
Owner: set to dgoulet

comment:3 Changed 6 years ago by dgoulet

Thanks for this! Merged and upstream!

comment:4 Changed 6 years ago by dgoulet

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.