Opened 5 years ago

Closed 5 years ago

#14184 closed defect (fixed)

Control port command "getinfo entry-guards" return all guards with the "up" state

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.10
Severity: Keywords: tor-client controller nickm-review
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

getinfo entry-guards returns a list of guards that are all flagged as "up" even though the state file shows only one of them is actually up and all others are down.

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-final

comment:2 Changed 5 years ago by dgoulet

Status: newneeds_review

See branch bug14184_026_v1 for the fix.

Output to a "getinfo entry-guards" looks like this now:

$B777D4C844AD769CB996046B462349617DDADEEA~Unnamed down-since 2015-01-25 16:48:55
$0C9B3C686421C5A8C20BAA0D7369CD929F43A174 unusable 2015-01-23 16:41:42
$E3F98C86C9E01138DD8EA06B1E660A0CDB4B2782~Finisterre up
$7FA119BC0A7450402DCE9DD9BC0F868BCBE01CA2~pipeepvenetx up
$5A16F7E31B26F286889F20027F57A5E253AF3F23~servbr4a down-since 2015-01-25 20:36:12
$D369D86310CBC8FFBE064940B55458C754F1B03C~Kyat1 up

comment:3 Changed 5 years ago by atagar

Just quick food for thought that this will limit you a bit in adding additional fields. When you look at parsing...

$0C9B3C686421C5A8C20BAA0D7369CD929F43A174 unusable 2015-01-23 16:41:42

... verses...

$E3F98C86C9E01138DD8EA06B1E660A0CDB4B2782~Finisterre up

The first has four space separated entries and the later two. This is fine for now but it means that if we want to add a new field to the end in the future...

$0C9B3C686421C5A8C20BAA0D7369CD929F43A174 unusable 2015-01-23 16:41:42 stegosaurus
$E3F98C86C9E01138DD8EA06B1E660A0CDB4B2782~Finisterre up triceratops

... parsers will have a hassle with this optional date.

comment:4 in reply to:  3 Changed 5 years ago by dgoulet

Replying to atagar:

Just quick food for thought that this will limit you a bit in adding additional fields. When you look at parsing...

$0C9B3C686421C5A8C20BAA0D7369CD929F43A174 unusable 2015-01-23 16:41:42

This one is already upstream so using "down-since" instead of "unusable" shouldn't be a problem for parser. (well except the fact that it's an ABI extension :).

comment:5 Changed 5 years ago by nickm

Keywords: nickm-review added

current status: dgoulet says atagar is okay with this; dgoulet is writing the control-spec patch; I'm reviewing the code.

comment:6 Changed 5 years ago by nickm

patch looks okay but needs a changes file

comment:7 Changed 5 years ago by dgoulet

Small modification to replace "down-since" to "down" that is already in the control spec. Also, add a change file.

See branch bug14184_026_v2
Spec. fix in branch ticket14184_01 found here: https://git.torproject.org/user/dgoulet/torspec.git

comment:8 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks good; merged!

Note: See TracTickets for help on using tickets.