Opened 6 years ago

Closed 6 years ago

#14193 closed defect (fixed)

set *expires_out correctly in addressmap_rewrite

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client, nickm-patch, asn-review
Cc: Actual Points:
Parent ID: #14192 Points:
Reviewer: Sponsor:


Right now, *expires_out is set unconditionally to TIME_MAX at the end of addressmap_rewrite. That's wrong.

Child Tickets

Change History (5)

comment:1 Changed 6 years ago by nickm

Keywords: tor-client nickm-patch added
Status: newneeds_review

There's a fix for this in my bug7555_v2 branch. Don't review it yet, though.

comment:2 Changed 6 years ago by nickm

Keywords: asn-review added

comment:3 Changed 6 years ago by nickm

You can review it now; the branch is done.

comment:4 Changed 6 years ago by asn

I reviewed commit 2e1ed0815d3f4 and it looked good to me.

comment:5 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged as part of #7555.

Note: See TracTickets for help on using tickets.